-
Notifications
You must be signed in to change notification settings - Fork 159
feat(overlay) use popover in overlay service #16835
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
wnvko
wants to merge
18
commits into
master
Choose a base branch
from
mvenkov/use-popover-in-overlay
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+436
−117
Open
Changes from 1 commit
Commits
Show all changes
18 commits
Select commit
Hold shift + click to select a range
6a757f9
feat(overlay): use popover in overlay service
wnvko 7b4cac3
test(combo): fix combo issue and failing tests
wnvko 851912e
fix(overlay): fix container position strategy
wnvko 532ddca
test(overlay): fix failing tests
wnvko 0788eaf
Merge branch 'master' into mvenkov/use-popover-in-overlay
wnvko 6124cec
chore(overlay): update change log and read me
wnvko d09d90d
chore(overlay): simplify null check
wnvko 6b1ef0a
fix(overlay): force overlay to initially show and revert combo changes
wnvko 132920e
Merge remote-tracking branch 'remotes/origin/master' into mvenkov/use…
wnvko d09b208
test(overlay): should retain position in container when container get…
wnvko 9900333
fix(overlay): ensure container resize does not break position and dis…
wnvko bae50de
fix(overlay): use build in resizeObservable
wnvko 323daaf
chore(*): fix CHANGELOG.md
wnvko 04f1e87
chore(overlay): add TODO for anchor() CSS function
wnvko b606194
Merge branch 'master' into mvenkov/use-popover-in-overlay
gedinakova 7b06e35
Merge branch 'master' into mvenkov/use-popover-in-overlay
gedinakova 5798a10
fix(overlay): use IntersectionObserver to position the overlay conten…
wnvko 1dcc482
Merge branch 'master' into mvenkov/use-popover-in-overlay
damyanpetev File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.