Skip to content

[Do not merge] IgxTabs/IgxBottonNav routing support POC #4500

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 18 commits into from
Closed

[Do not merge] IgxTabs/IgxBottonNav routing support POC #4500

wants to merge 18 commits into from

Conversation

rmkrmk
Copy link
Contributor

@rmkrmk rmkrmk commented Apr 10, 2019

#4297

Additional information (check all that apply):

  • Bug fix
  • New functionality
  • Documentation
  • Demos
  • CI/CD

Checklist:

  • All relevant tags have been applied to this PR
  • This PR includes unit tests covering all the new code
  • This PR includes API docs for newly added methods/properties
  • This PR includes feature/README.MD updates for the feature docs
  • This PR includes general feature table updates in the root README.MD
  • This PR includes CHANGELOG.MD updates for newly added functionality
  • This PR contains breaking changes
  • This PR includes ng update migrations for the breaking changes
  • This PR includes behavioral changes and the feature specification has been updated with them

@rmkrmk rmkrmk added bottom-nav Bottom navigation component tabs ❌ do not merge labels Apr 10, 2019
@rmkrmk rmkrmk requested a review from kdinev April 10, 2019 08:17
kdinev
kdinev previously approved these changes Apr 12, 2019
View reviewed changes
@kdinev kdinev added 🛠️ status: in-development Issues and PRs with active development on them version: 7.2.x and removed ❌ do not merge labels Apr 12, 2019
@rmkrmk
Copy link
Contributor Author

rmkrmk commented Jun 7, 2019

Closing this PR because this approach will not be used.

@rmkrmk rmkrmk closed this Jun 7, 2019
@rmkrmk rmkrmk deleted the rkolev/igxBottonNavigationRoutingLinks branch June 7, 2019 07:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kdinev kdinev kdinev left review comments

Assignees
No one assigned
Labels
bottom-nav Bottom navigation component 🛠️ status: in-development Issues and PRs with active development on them tabs version: 7.2.x
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@rmkrmk @kdinev