Skip to content

labels feature and refactoring SLIDER #4996

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
zdrawku merged 11 commits into from
Jun 7, 2019
Merged

labels feature and refactoring SLIDER #4996

zdrawku merged 11 commits into from
Jun 7, 2019

Conversation

@Aleksandyr
Copy link
Contributor

@Aleksandyr Aleksandyr commented Jun 5, 2019 •
edited
Loading

Closes #3449
Closes #4562
Closes #4559
Closes #2622

Additional information (check all that apply):

  • Bug fix
  • New functionality
  • Documentation
  • Demos
  • CI/CD

Checklist:

  • All relevant tags have been applied to this PR
  • This PR includes unit tests covering all the new code
  • This PR includes API docs for newly added methods/properties
  • This PR includes feature/README.MD updates for the feature docs
  • This PR includes general feature table updates in the root README.MD
  • This PR includes CHANGELOG.MD updates for newly added functionality
  • This PR contains breaking changes
  • This PR includes ng update migrations for the breaking changes
  • This PR includes behavioral changes and the feature specification has been updated with them

@Aleksandyr Aleksandyr requested review from nrobakova and zdrawku June 5, 2019 14:46
@Aleksandyr
Copy link
Contributor Author

Aleksandyr commented Jun 5, 2019

API documentation should be updated.

@Aleksandyr Aleksandyr changed the title merge labels feature slider labels feature and refactoring SLIDER Jun 5, 2019
@Aleksandyr Aleksandyr added ✅ status: verified Applies to PRs that have passed manual verification and removed ❌ do not merge ❌ status: awaiting-test PRs awaiting manual verification labels Jun 6, 2019
@nrobakova nrobakova self-assigned this Jun 6, 2019
@nrobakova nrobakova added 💥 status: in-test PRs currently being tested and removed ✅ status: verified Applies to PRs that have passed manual verification labels Jun 6, 2019
@nrobakova nrobakova added ✅ status: verified Applies to PRs that have passed manual verification and removed 💥 status: in-test PRs currently being tested labels Jun 6, 2019
nrobakova
nrobakova previously approved these changes Jun 6, 2019
View reviewed changes
zdrawku
zdrawku previously approved these changes Jun 7, 2019
View reviewed changes
@Aleksandyr Aleksandyr dismissed stale reviews from zdrawku and nrobakova via ac06e62 June 7, 2019 07:58
@zdrawku zdrawku merged commit e0ef99c into 7.3.x Jun 7, 2019
@zdrawku zdrawku deleted the slider-labels-feature-7.3.x branch June 7, 2019 09:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@zdrawku zdrawku zdrawku approved these changes

+1 more reviewer

@nrobakova nrobakova nrobakova left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

@nrobakova nrobakova

Labels

feature refactoring slider version: 7.3.x ✅ status: verified Applies to PRs that have passed manual verification

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@Aleksandyr @zdrawku @nrobakova