style(drop-down): Adding classes for different density types #5036
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
desig9stein
added
📈 enhancement
styling
❌ status: awaiting-test
PlamenaMiteva
added
💥 status: in-test
PlamenaMiteva
added
✅ status: verified
wnvko
changed the title
wnvko
requested changes
Jun 18, 2019
| @@ -196,6 +212,22 @@ export abstract class IgxDropDownItemBase implements DoCheck { | |||
| @HostBinding('class.igx-drop-down__header') | |||
| public isHeader: boolean; | |||
|
|
|||
| /** | |||
There was a problem hiding this comment.
drop down could update its items display density via hidden input. This way items will not know about drop down. Other possible solution is to use some service to update display density of the items.
There was a problem hiding this comment.
I believe this would be better left for another PR - in order for the drop-down item to not know about it's parent, the remaining selection logic and the allowItemFocus handling inside of the drop-down-item component will have to be abstracted in a service as well
projects/igniteui-angular/src/lib/drop-down/drop-down.common.ts
Outdated
Show resolved
Hide resolved
projects/igniteui-angular/src/lib/select/select-positioning-strategy.ts
Outdated
Show resolved
Hide resolved
…pec, #5034 # Conflicts: # projects/igniteui-angular/src/lib/drop-down/drop-down.component.spec.ts
…on strat; # Conflicts: # projects/igniteui-angular/src/lib/drop-down/drop-down.common.ts
damyanpetev
reviewed
Jun 19, 2019
projects/igniteui-angular/src/lib/drop-down/drop-down.component.spec.ts
Outdated
Show resolved
Hide resolved
damyanpetev
approved these changes
Jun 19, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #2960
Additional information (check all that apply):
Checklist:
feature/README.MDupdates for the feature docsREADME.MDCHANGELOG.MDupdates for newly added functionalityng updatemigrations for the breaking changes