Skip to content

refactor(themes): add square and oval presets in schemas #5084

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 8 commits into from
Jun 19, 2019
Merged

refactor(themes): add square and oval presets in schemas #5084

merged 8 commits into from
Jun 19, 2019

Conversation

simeonoff
Copy link
Collaborator

@simeonoff simeonoff commented Jun 17, 2019 •
edited
Loading

Closes #4964

Additional information (check all that apply):

  • Bug fix
  • New functionality
  • Documentation
  • Demos
  • CI/CD

Checklist:

  • All relevant tags have been applied to this PR
  • This PR includes unit tests covering all the new code
  • This PR includes API docs for newly added methods/properties
  • This PR includes feature/README.MD updates for the feature docs
  • This PR includes general feature table updates in the root README.MD
  • This PR includes CHANGELOG.MD updates for newly added functionality
  • This PR contains breaking changes
  • This PR includes ng update migrations for the breaking changes
  • This PR includes behavioral changes and the feature specification has been updated with them

@simeonoff simeonoff requested review from kdinev and desig9stein June 17, 2019 11:26
@kdinev
Copy link
Member

kdinev commented Jun 17, 2019

@simeonoff Could you please resolve with the list updates?

desig9stein
desig9stein previously approved these changes Jun 18, 2019
View reviewed changes
@simeonoff simeonoff requested a review from desig9stein June 19, 2019 07:30
desig9stein
desig9stein previously approved these changes Jun 19, 2019
View reviewed changes
@desig9stein desig9stein added ✅ status: verified Applies to PRs that have passed manual verification and removed ❌ status: awaiting-test PRs awaiting manual verification labels Jun 19, 2019
kdinev
kdinev previously approved these changes Jun 19, 2019
View reviewed changes
@simeonoff simeonoff dismissed stale reviews from kdinev and desig9stein via 573accc June 19, 2019 11:15
@kdinev kdinev merged commit cb52911 into master Jun 19, 2019
@kdinev kdinev deleted the shape-schema-presets branch June 19, 2019 11:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kdinev kdinev kdinev approved these changes

@desig9stein desig9stein desig9stein left review comments

Assignees

@desig9stein desig9stein

Labels
material-theme version: 8.0.x ✅ status: verified Applies to PRs that have passed manual verification
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[igx-nav-drawer][Sass] $border-radius doesn't change igxDrawerItem roundness.
3 participants
@simeonoff @kdinev @desig9stein