Skip to content

feat(fluent theme): Initial implementation #5336

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 54 commits into from
Aug 26, 2019
Merged

feat(fluent theme): Initial implementation #5336

merged 54 commits into from
Aug 26, 2019

Conversation

desig9stein
Copy link
Contributor

@desig9stein desig9stein commented Jul 5, 2019 •
edited
Loading

Closes #5335

Additional information (check all that apply):

  • Bug fix
  • New functionality
  • Documentation
  • Demos
  • CI/CD

Checklist:

  • All relevant tags have been applied to this PR
  • This PR includes unit tests covering all the new code
  • This PR includes API docs for newly added methods/properties
  • This PR includes feature/README.MD updates for the feature docs
  • This PR includes general feature table updates in the root README.MD
  • This PR includes CHANGELOG.MD updates for newly added functionality
  • This PR contains breaking changes
  • This PR includes ng update migrations for the breaking changes
  • This PR includes behavioral changes and the feature specification has been updated with them

@desig9stein desig9stein requested a review from simeonoff July 5, 2019 12:33
MPopov and others added 16 commits July 8, 2019 09:41
feat(fluent theme): Adding function to handle multiple map merges
d770003
feat(fluent theme): Adding theme styles for chp,drop-down and button …
e492cd6 
…group
@simeonoff
Merge branch 'master' into fluent-theme
7db8015
feat(fluent theme): Combo/dropdown theme
ace65ff
Merge remote-tracking branch 'IGX/fluent-theme' into fluent-theme
7012cf7
feat(fluent theme): adding fluent switch theme and fix some drop-down…
808b53e 
… colors
Merge branch 'master' of https://github.com/IgniteUI/igniteui-angular …
d31bb6e 
…into fluent-theme
feat(fluent theme): Adding fluent radio and checkbox themes
e6b7f5c
feat(fluent theme): Fix some issues in fluent button/checkbox/radio t…
50829df 
…hemes
Merge branch 'master' of https://github.com/IgniteUI/igniteui-angular …
42f6a56 
…into fluent-theme
feat(fluent theme): Adding fluent theme for slider component
abccc38
Merge branch 'master' of https://github.com/IgniteUI/igniteui-angular …
9b32efe 
…into fluent-theme
feat(fluent theme): initial commit fot fluent input
5ce8ee7
Merge branch 'master' of https://github.com/IgniteUI/igniteui-angular …
fbcf11e 
…into fluent-theme
feat(fluent theme): improve fluent input theme
b74ee55
style(fluent theme): Merge master and fix all conflicts comming from …
c9dc5cf 
…the elevation changes
@desig9stein desig9stein changed the title feat(fluent theme): Initial commit feat(fluent theme): Initial implementation Jul 15, 2019
@kdinev
Copy link
Member

kdinev commented Aug 19, 2019

@ChronosSF @desig9stein The changes affect some of the grid sizing tests. Please investigate.

@kdinev kdinev requested a review from ChronosSF August 19, 2019 07:49
kdinev
kdinev previously approved these changes Aug 19, 2019
View reviewed changes
@desig9stein desig9stein dismissed stale reviews from kdinev and simeonoff via 4a8ace8 August 20, 2019 14:05
MPopov and others added 4 commits August 21, 2019 09:51
Remove fdescribe to run all tests
1be97ce
@kdinev
Merge branch 'master' into fluent-theme
7730344
Merge branch 'master' of https://github.com/IgniteUI/igniteui-angular …
4e8c731 
…into fluent-theme

# Conflicts:
#	projects/igniteui-angular/src/lib/core/styles/components/calendar/_calendar-theme.scss
#	projects/igniteui-angular/src/lib/core/styles/themes/schemas/dark/_calendar.scss
#	projects/igniteui-angular/src/lib/core/styles/themes/schemas/light/_calendar.scss
test(grid): Fix failing tests
4ca2368
@desig9stein desig9stein added ❌ status: awaiting-test PRs awaiting manual verification and removed ❌ do not merge labels Aug 23, 2019
@simeonoff simeonoff requested review from kdinev and simeonoff August 23, 2019 14:26
simeonoff
simeonoff previously approved these changes Aug 23, 2019
View reviewed changes
@desig9stein desig9stein removed the ❌ status: awaiting-test PRs awaiting manual verification label Aug 26, 2019
simeonoff and others added 3 commits August 26, 2019 11:02
@simeonoff
Merge branch 'master' into fluent-theme
7a04d37
Merge branch 'master' of https://github.com/IgniteUI/igniteui-angular …
f7047da 
…into fluent-theme

# Conflicts:
#	projects/igniteui-angular/src/lib/core/styles/components/chip/_chip-theme.scss
#	projects/igniteui-angular/src/lib/core/styles/themes/schemas/elevation/_chip.scss
fix(chip): rename prop names
d34d1dd
@zdrawku zdrawku merged commit 4dc4821 into master Aug 26, 2019
@zdrawku zdrawku deleted the fluent-theme branch August 26, 2019 13:04
@desig9stein desig9stein mentioned this pull request Aug 29, 2019
Merged
14 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zdrawku zdrawku zdrawku approved these changes

@simeonoff simeonoff simeonoff left review comments

@ChronosSF ChronosSF Awaiting requested review from ChronosSF

@kdinev kdinev Awaiting requested review from kdinev

Assignees

@desig9stein desig9stein

Labels
📈 enhancement fluent-theme material-theme version: 8.2.x ✅ status: verified Applies to PRs that have passed manual verification
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Implementing a new theme based on Microsoft fluent design
5 participants
@desig9stein @kdinev @simeonoff @zdrawku @Lipata