Skip to content

Adding igxDragCustomGhost directive #6105

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 21 commits into from
Nov 8, 2019
Merged

Adding igxDragCustomGhost directive #6105

merged 21 commits into from
Nov 8, 2019

Conversation

dafo
Copy link
Contributor

@dafo dafo commented Oct 31, 2019 •
edited
Loading

Closes #6081

Additional information (check all that apply):

  • Bug fix
  • New functionality
  • Documentation
  • Demos
  • CI/CD

Checklist:

  • All relevant tags have been applied to this PR
  • This PR includes unit tests covering all the new code
  • This PR includes API docs for newly added methods/properties
  • This PR includes feature/README.MD updates for the feature docs
  • This PR includes general feature table updates in the root README.MD
  • This PR includes CHANGELOG.MD updates for newly added functionality
  • This PR contains breaking changes
  • This PR includes ng update migrations for the breaking changes
  • This PR includes behavioral changes and the feature specification has been updated with them

damyanpetev
damyanpetev reviewed Nov 1, 2019
View reviewed changes
Copy link
Member

@damyanpetev damyanpetev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Update branch w/ master before continuing

@dafo
Copy link
Contributor Author

dafo commented Nov 2, 2019

All current comments are addressed. I have updated the igxGrid and igxHierarchicalGrid demos.
Need to add test + docs.

@dafo dafo marked this pull request as ready for review November 3, 2019 07:39
@dafo dafo added the ❌ status: awaiting-test PRs awaiting manual verification label Nov 3, 2019
skrustev
skrustev previously approved these changes Nov 4, 2019
View reviewed changes
@wnvko wnvko added 💥 status: in-test PRs currently being tested and removed ❌ status: awaiting-test PRs awaiting manual verification labels Nov 5, 2019
@wnvko wnvko self-assigned this Nov 5, 2019
@wnvko
Copy link
Contributor

wnvko commented Nov 5, 2019

It is not possible to set row drag template for HierarchicalGrid's child grids.

@wnvko wnvko removed their assignment Nov 5, 2019
@wnvko wnvko added 🛠️ status: in-development Issues and PRs with active development on them and removed 💥 status: in-test PRs currently being tested labels Nov 5, 2019
@MonikaKirkova MonikaKirkova self-assigned this Nov 6, 2019
@dafo dafo added ❌ status: awaiting-test PRs awaiting manual verification and removed 🛠️ status: in-development Issues and PRs with active development on them labels Nov 6, 2019
@MonikaKirkova MonikaKirkova added ✅ status: verified Applies to PRs that have passed manual verification and removed ❌ status: awaiting-test PRs awaiting manual verification labels Nov 7, 2019
@damyanpetev damyanpetev added the squash-merge Merge PR with "Squash and Merge" option label Nov 8, 2019
@damyanpetev damyanpetev merged commit bd3f27e into master Nov 8, 2019
@damyanpetev damyanpetev deleted the amarinov/issue6081_master branch November 8, 2019 17:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@damyanpetev damyanpetev damyanpetev approved these changes

@skrustev skrustev skrustev left review comments

@Lipata Lipata Awaiting requested review from Lipata

Assignees

@MonikaKirkova MonikaKirkova

Labels
drag-drop grid: general grid: hierarchical-grid grid: row-drag grid: tree-grid squash-merge Merge PR with "Squash and Merge" option version: 9.0.x ✅ status: verified Applies to PRs that have passed manual verification
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Directive for custom row drag ghost in the grids
5 participants
@dafo @wnvko @damyanpetev @skrustev @MonikaKirkova