-
Notifications
You must be signed in to change notification settings - Fork 160
Grid Master Detail #6119
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Grid Master Detail #6119
Changes from all commits
Commits
Show all changes
65 commits
Select commit
Hold shift + click to select a range
32ff076
feat(igxGrid): Master-detail view in grid - initial commit.
66d2d66
chore(*): KB expand/collapse with Alt+arrow keys.
7ec8158
chore(*): In case template is destroyed make sure cached view is deta…
52ab3a2
chore(*): Adding dev sample. Including public APIs.
a42a70d
chore(*): Fixing template. Adding kb nav handling for detail row. Upd…
941460c
chore(*): Minor fixes.
3b8c4a6
chore(*): Fixing some tests.
8d857c5
chore(*): Fixing additional template issues.
5899855
chore(*): Fixing mrl tests.
bb21829
chore(*): Fixing lint.
12a3d65
chore(*): Apply group row offsets to details content so that they rem…
450d8d9
chore(*): Handling additional edge cases for kb nav with tab/shift+ta…
a834456
Merge branch 'master' into mkirova/grid-master-detail
ChronosSF a0b537d
chore(*): Adding toggleRow API as per the spec.
2f6fcb8
chore(*): Merge from master.
48598fd
tests(master-detail): Add initial igxGrid Master Detail spec and scen…
skrustev 901d8b8
Merge branch 'master' into mkirova/grid-master-detail
ChronosSF 0ce0048
Merge branch 'master' into mkirova/grid-master-detail
ChronosSF bbed683
chore(*): Adding basic API tests.
882f6d7
chore(*): Adding kb up/down tests.
58c6bbf
test(mdv): adding paging tests #5880
ChronosSF c06a86e
chore(*): cross merge from upstream
ChronosSF eaaa95c
test(mdv): adding more integration tests #5880
ChronosSF 4f856d7
chore(*): Adding more kbnav tests.
2e7da3a
chore(*): Fixing minor bug. Re-enabling related test.
769b457
chore(*): Fixing lint.
5c81779
chore(*): Fixing test imports.
2fa0a2d
Merge branch 'master' into mkirova/grid-master-detail
ChronosSF 35f4f73
chore(*): Adding more intergration scenarios.
705e1a0
Merge branch 'mkirova/grid-master-detail' of https://github.com/Ignit…
973ea9d
chore(*): Adding a few more kb nav scenarios + minor fix.
f1b60e0
chore(*): Add more test scenarios
skrustev 300002d
chore(*): Adding a few more tests and minor fixes.
9d48617
Merge branch 'mkirova/grid-master-detail' of https://github.com/Ignit…
9e4a82c
test(mdv): adding cell selection test #5880
ChronosSF 51da071
chore(*): cross merge from upstream
ChronosSF e2e414a
Merge branch 'master' into mkirova/grid-master-detail
ChronosSF ef753df
test(mdv): adding row selection tests #5880
ChronosSF 798de0c
chore(*): Adding more tests + fixes for MRL + Details Views kb nav.
20f3ec6
Merge branch 'mkirova/grid-master-detail' of https://github.com/Ignit…
1c3a068
chore(*): Adding more tests.
8a3977a
Merge branch 'master' into mkirova/grid-master-detail
ChronosSF 349787e
Merge branch 'master' into mkirova/grid-master-detail
ChronosSF a2a95a9
chore(*): Fix issue with navigation in case details view contain a grid.
19a5909
Merge branch 'mkirova/grid-master-detail' of https://github.com/Ignit…
0c417eb
Merge branch 'master' into mkirova/grid-master-detail
kdinev ed7f2ff
docs(*): adding changelog for MDV #5880
ChronosSF df111a4
chore(*): Fix failing tests.
1467d27
Merge branch 'mkirova/grid-master-detail' of https://github.com/Ignit…
c692ef3
chore(*): Fix for additional mdv + kb nav scenarios.
90794be
Merge branch 'master' into mkirova/grid-master-detail
ChronosSF fbe2c28
chore(*): Fix for intergration scenarios with pinning when expandable…
d628aa7
Merge branch 'mkirova/grid-master-detail' of https://github.com/Ignit…
1c49aac
Merge branch 'master' into mkirova/grid-master-detail
kdinev 4dc6372
chore(*): Applying changes after code review.
086d377
Merge branch 'mkirova/grid-master-detail' of https://github.com/Ignit…
d905ea2
Merge branch 'master' into mkirova/grid-master-detail
ChronosSF a14d068
chore(*): Removing handling for tab/shift+tab from/to last element fo…
eff1249
Merge branch 'mkirova/grid-master-detail' of https://github.com/Ignit…
f82b923
chore(*): Fixing test.
1442945
Merge branch 'master' into mkirova/grid-master-detail
ChronosSF a57ddc6
Merge branch 'master' into mkirova/grid-master-detail
MayaKirova 41e5472
Merge branch 'master' into mkirova/grid-master-detail
ChronosSF 2424060
Merge branch 'master' into mkirova/grid-master-detail
ChronosSF f958a91
Merge branch 'master' into mkirova/grid-master-detail
ChronosSF File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
43 changes: 43 additions & 0 deletions
43
projects/igniteui-angular/src/lib/grids/grid/expandable-cell.component.html
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,43 @@ | ||
<ng-template #defaultCell> | ||
<div igxTextHighlight style="pointer-events: none" [cssClass]="highlightClass" [activeCssClass]="activeHighlightClass" [groupName]="gridID" | ||
[value]="formatter ? formatter(value) : column.dataType === 'number' ? (value | igxdecimal: grid.locale) : column.dataType === 'date' ? (value | igxdate: grid.locale) : value" | ||
[row]="rowData" [column]="this.column.field" [containerClass]="'igx-grid__td-text'" | ||
class="igx-grid__td-text">{{ formatter ? formatter(value) : column.dataType === 'number' ? (value | igxdecimal: | ||
grid.locale) : column.dataType === 'date' ? (value | igxdate: grid.locale) : value }}</div> | ||
</ng-template> | ||
<ng-template #inlineEditor let-cell="cell"> | ||
<ng-container *ngIf="column.dataType === 'string'"> | ||
<igx-input-group displayDensity="compact"> | ||
<input igxInput [(ngModel)]="editValue" [igxFocus]="focused"> | ||
</igx-input-group> | ||
</ng-container> | ||
<ng-container *ngIf="column.dataType === 'number'"> | ||
<igx-input-group displayDensity="compact"> | ||
<input igxInput [(ngModel)]="editValue" [igxFocus]="focused" type="number"> | ||
</igx-input-group> | ||
</ng-container> | ||
<ng-container *ngIf="column.dataType === 'boolean'"> | ||
<igx-checkbox (change)="editValue = $event.checked" [value]="editValue" [checked]="editValue" [disableRipple]="true"></igx-checkbox> | ||
</ng-container> | ||
<ng-container *ngIf="column.dataType === 'date'"> | ||
<igx-date-picker [style.width.%]="100" [outlet]="grid.outletDirective" mode="dropdown" | ||
[locale]="grid.locale" [(value)]="editValue" [igxFocus]="focused" [labelVisibility]="false"> | ||
</igx-date-picker> | ||
</ng-container> | ||
</ng-template> | ||
<ng-container *ngIf="!editMode"> | ||
<div #indicator | ||
class="igx-grid__tree-grouping-indicator" | ||
(click)="toggle($event)" (focus)="onIndicatorFocus()" tabindex="-1"> | ||
<ng-container *ngTemplateOutlet="iconTemplate; context: { $implicit: this }"> | ||
</ng-container> | ||
</div> | ||
</ng-container> | ||
<ng-container *ngTemplateOutlet="template; context: context"> | ||
</ng-container> | ||
<ng-template #defaultExpandedTemplate> | ||
<igx-icon fontSet="material">expand_more</igx-icon> | ||
</ng-template> | ||
<ng-template #defaultCollapsedTemplate> | ||
<igx-icon fontSet="material">chevron_right</igx-icon> | ||
</ng-template> |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This won't always persist the focus on the right cell element as
notifyChanges
is run on the next detection cycle and the layout of the grid body can shift up/downThere was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Related to #6191