Skip to content

fix(#6292): scroll speed for timepicker on mobile devices to high #6293

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

robertjanetzko
Copy link

Closes #6292

Additional information (check all that apply):

  • Bug fix
  • New functionality
  • Documentation
  • Demos
  • CI/CD

Checklist:

  • All relevant tags have been applied to this PR
  • This PR includes unit tests covering all the new code
  • This PR includes API docs for newly added methods/properties
  • This PR includes feature/README.MD updates for the feature docs
  • This PR includes general feature table updates in the root README.MD
  • This PR includes CHANGELOG.MD updates for newly added functionality
  • This PR contains breaking changes
  • This PR includes ng update migrations for the breaking changes
  • This PR includes behavioral changes and the feature specification has been updated with them

@Lipata
Copy link
Member

Lipata commented Dec 12, 2019

@robertjanetzko, thank you for contributing to our product!

For touch gestures, we are using hammers.js. We are currently trying to configure the scroll step using hammer.js settings and if we succeed we will inform you and we will prefer to use such an implementation. Please tell me how you want to proceed with the following pull request - do you prefer guidance and to apply comments that we will suggest, or you prefer that we take care of that implementation. Thank you!

@Lipata
Copy link
Member

Lipata commented Jan 7, 2020

@robertjanetzko I have put a comment with an update on the #6292 issue.

@kdinev
Copy link
Member

kdinev commented Mar 23, 2020

@Lipata @robertjanetzko @radomirchev This has been sitting in the queue for quite some time. Please consider it for the upcoming sprint.

@Lipata
Copy link
Member

Lipata commented Mar 23, 2020

@robertjanetzko we will take care of that feature in the future. I will close that PR.

@Lipata Lipata closed this Mar 23, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants