Skip to content

Mask refactoring #6455

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 8 commits into from
Mar 2, 2020
Merged

Mask refactoring #6455

merged 8 commits into from
Mar 2, 2020

Conversation

jackofdiamond5
Copy link
Member

@jackofdiamond5 jackofdiamond5 commented Jan 13, 2020 •
edited by IvayloG
Loading

Closes #6454, -tested
Fixes #6710, -tested
Fixes #6784, -tested
Fixes #6783,
Fixes #6712, -tested
Fixes #6832 -tested

Additional information (check all that apply):

  • Bug fix
  • New functionality
  • Documentation
  • Demos
  • CI/CD

Checklist:

  • All relevant tags have been applied to this PR
  • This PR includes unit tests covering all the new code
  • This PR includes API docs for newly added methods/properties
  • This PR includes feature/README.MD updates for the feature docs
  • This PR includes general feature table updates in the root README.MD
  • This PR includes CHANGELOG.MD updates for newly added functionality
  • This PR contains breaking changes
  • This PR includes ng update migrations for the breaking changes
  • This PR includes behavioral changes and the feature specification has been updated with them

@jackofdiamond5 jackofdiamond5 added ❌ status: awaiting-test PRs awaiting manual verification mask-editor labels Jan 13, 2020
@Lipata Lipata mentioned this pull request Jan 17, 2020
Closed
16 tasks
@Lipata
Copy link
Member

Lipata commented Jan 21, 2020 •
edited
Loading

We will not merge this, until [email protected] is released, becasue it is needed for the component for the next milestone.

damyanpetev
damyanpetev previously approved these changes Jan 23, 2020
View reviewed changes
Copy link
Member

@damyanpetev damyanpetev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
Only need to clarify the change to paste handling support down the line

@Lipata Lipata added 💥 status: in-test PRs currently being tested 🛠️ status: in-development Issues and PRs with active development on them and removed ❌ status: awaiting-test PRs awaiting manual verification 💥 status: in-test PRs currently being tested labels Jan 24, 2020
@Lipata
Copy link
Member

Lipata commented Jan 24, 2020

Paste should be supported in IE

@jackofdiamond5 jackofdiamond5 added ❌ status: awaiting-test PRs awaiting manual verification squash-merge Merge PR with "Squash and Merge" option and removed 🛠️ status: in-development Issues and PRs with active development on them labels Feb 14, 2020
@damyanpetev damyanpetev added version: 9.1.x and removed squash-merge Merge PR with "Squash and Merge" option labels Feb 19, 2020
@jackofdiamond5 jackofdiamond5 force-pushed the bpenkov/mask-refactor branch 2 times, most recently from b54be61 to 397d5b8 Compare February 25, 2020 14:44
@jackofdiamond5
refactor(igxMask): cleanup/streamline parsing and input handling
15e37c4 
- input parsing go through one method
- add drag and drop functionality
- set default value on mask prop
@IvayloG IvayloG added 💥 status: in-test PRs currently being tested and removed ❌ status: awaiting-test PRs awaiting manual verification labels Feb 27, 2020
rkaraivanov
rkaraivanov previously approved these changes Feb 28, 2020
View reviewed changes
damyanpetev
damyanpetev previously approved these changes Feb 28, 2020
View reviewed changes
@damyanpetev damyanpetev dismissed stale reviews from rkaraivanov and themself via 19127db February 28, 2020 15:42
damyanpetev
damyanpetev previously approved these changes Feb 28, 2020
View reviewed changes
@ViktorSlavov ViktorSlavov added ✅ status: verified Applies to PRs that have passed manual verification 💥 status: in-test PRs currently being tested and removed 💥 status: in-test PRs currently being tested ✅ status: verified Applies to PRs that have passed manual verification labels Mar 2, 2020
@ViktorSlavov ViktorSlavov added ✅ status: verified Applies to PRs that have passed manual verification and removed 💥 status: in-test PRs currently being tested labels Mar 2, 2020
@damyanpetev damyanpetev merged commit 8ca9c0e into master Mar 2, 2020
@damyanpetev damyanpetev deleted the bpenkov/mask-refactor branch March 2, 2020 12:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@damyanpetev damyanpetev damyanpetev approved these changes

@rkaraivanov rkaraivanov rkaraivanov left review comments

Assignees

@IvayloG IvayloG

@ViktorSlavov ViktorSlavov

Labels
mask-editor refactoring version: 9.1.x ✅ status: verified Applies to PRs that have passed manual verification
Projects
None yet
Milestone
No milestone
6 participants
@jackofdiamond5 @Lipata @damyanpetev @rkaraivanov @IvayloG @ViktorSlavov