Skip to content

feat(time-picker): add disabled styles for values #6458

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 8 commits into from
Jan 20, 2020
Merged

feat(time-picker): add disabled styles for values #6458

merged 8 commits into from
Jan 20, 2020

Conversation

simeonoff
Copy link
Collaborator

Related #3978

Additional information (check all that apply):

  • Bug fix
  • New functionality
  • Documentation
  • Demos
  • CI/CD

Checklist:

  • All relevant tags have been applied to this PR
  • This PR includes unit tests covering all the new code
  • This PR includes API docs for newly added methods/properties
  • This PR includes feature/README.MD updates for the feature docs
  • This PR includes general feature table updates in the root README.MD
  • This PR includes CHANGELOG.MD updates for newly added functionality
  • This PR contains breaking changes
  • This PR includes ng update migrations for the breaking changes
  • This PR includes behavioral changes and the feature specification has been updated with them

@simeonoff simeonoff requested a review from desig9stein January 13, 2020 14:07
desig9stein
desig9stein previously approved these changes Jan 13, 2020
View reviewed changes
@Lipata Lipata added 💥 status: in-test PRs currently being tested and removed ❌ status: awaiting-test PRs awaiting manual verification labels Jan 14, 2020
@Lipata
Copy link
Member

Lipata commented Jan 16, 2020 •
edited
Loading

The disabled time portion (hour/minute/AM or PM) should not be hovered.

@Lipata Lipata added 🛠️ status: in-development Issues and PRs with active development on them and removed 💥 status: in-test PRs currently being tested labels Jan 16, 2020
@Lipata Lipata added 💥 status: in-test PRs currently being tested ✅ status: verified Applies to PRs that have passed manual verification and removed 🛠️ status: in-development Issues and PRs with active development on them 💥 status: in-test PRs currently being tested labels Jan 17, 2020
@Lipata Lipata merged commit ef08da5 into master Jan 20, 2020
@Lipata Lipata deleted the time-picker-disabled-values branch January 20, 2020 12:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kdinev kdinev kdinev approved these changes

@desig9stein desig9stein desig9stein left review comments

Assignees

@Lipata Lipata

Labels
🕐 time-picker version: 9.0.x ✅ status: verified Applies to PRs that have passed manual verification
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@simeonoff @Lipata @kdinev @desig9stein @nrobakova