Skip to content

Add visual validity state and required asterisk for date and time pickers 8.2.x #6867

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
Lipata merged 33 commits into from
Mar 6, 2020
Merged

Add visual validity state and required asterisk for date and time pickers 8.2.x #6867

Lipata merged 33 commits into from
Mar 6, 2020

Conversation

@wnvko
Copy link
Contributor

@wnvko wnvko commented Mar 5, 2020 •
edited
Loading

Update the code to correctly handle state validity of the components

Closes #6471
Closes #6846

Additional information (check all that apply):

  • Bug fix
  • New functionality
  • Documentation
  • Demos
  • CI/CD

Checklist:

  • All relevant tags have been applied to this PR
  • This PR includes unit tests covering all the new code
  • This PR includes API docs for newly added methods/properties
  • This PR includes feature/README.MD updates for the feature docs
  • This PR includes general feature table updates in the root README.MD
  • This PR includes CHANGELOG.MD updates for newly added functionality
  • This PR contains breaking changes
  • This PR includes ng update migrations for the breaking changes
  • This PR includes behavioral changes and the feature specification has been updated with them

wnvko added 25 commits March 5, 2020 17:16
@wnvko
test(date-picker): add test for reactive form, #6471
d2c3096
@wnvko
fix(date-picker): fix validation of date picker, #6471
7065375 
# Conflicts:
#	projects/igniteui-angular/src/lib/date-picker/date-picker.component.ts

# Conflicts:
#	projects/igniteui-angular/src/lib/date-picker/date-picker.component.ts
@wnvko
test(date-picker): add test for control value accessor, #6471
2c89abc 
# Conflicts:
#	projects/igniteui-angular/src/lib/date-picker/date-picker.component.spec.ts
@wnvko
fix(time-picker): implement control value accessor, #6471
2e02f39 
# Conflicts:
#	projects/igniteui-angular/src/lib/time-picker/time-picker.component.ts

# Conflicts:
#	projects/igniteui-angular/src/lib/time-picker/time-picker.component.ts
@wnvko
chore(date-picker): remove fdescribe
9190a62
@wnvko
test(igx-calendar): fix failing test, #6471
6b0b7d9
@wnvko
fix(date-picker): updae ngModel on outside click, #6471
0e16cb2 
If we drop down the calendar when input has no value,
onBlur gets called but we do not call onTouchCallback
which is correct. However if after we click outside the
input the model is never validated. This is why we
should validate model, in this case, and in onClosing event.

# Conflicts:
#	projects/igniteui-angular/src/lib/time-picker/time-picker.component.ts
@wnvko
chore(date picker): add null check for input
3ba1ca0
@wnvko
test(date-picker): update test to correctly click, #6471
f1091e8
@wnvko
test(*): allow UIInteraction to click everywhere, #6471
925e3ff 
# Conflicts:
#	projects/igniteui-angular/src/lib/test-utils/ui-interactions.spec.ts
@wnvko
chore(input): add shouldCheckValidy
8f2143d 
Also force setting of this.validy to pass trouth setter always
@wnvko
fix(date-picker): stop input self validation, #6471
274b880
@wnvko
test(date-picker): fix failing test, #6471
8a2397d
@wnvko
chore(*): auto faormat revert
7563077
@wnvko
test(time-picker): fix failing tests, #6471
18a543f 
# Conflicts:
#	projects/igniteui-angular/src/lib/time-picker/time-picker.component.ts

# Conflicts:
#	projects/igniteui-angular/src/lib/time-picker/time-picker.component.ts
@wnvko
fix(date-picker): move isReaquired to ngAfterViewChecked, #6471
7f61ed4
@wnvko
test(date-picker): fix failing test, #6471
eb6be5b
@wnvko
chore(date-picker): update according to PR comments
fa76d42
@wnvko
chore(date-picker): updae _updateValidity to _updateValidityOnBlur
aaa56c6 
# Conflicts:
#	projects/igniteui-angular/src/lib/date-picker/date-picker.component.ts
@wnvko
test(date-picker): properly focus with no click, #6471
26482c7
@wnvko
chore(date-picker): make required private
776a175
@wnvko
chore(input): revert valid calls for a while
cfeb55a
@wnvko
chore(date-picker): update unit tests
a91a51c
@wnvko
chore(*): date and time ready for P.D.
a1eebb5 
# Conflicts:
#	projects/igniteui-angular/src/lib/date-picker/date-picker.component.ts
#	projects/igniteui-angular/src/lib/time-picker/time-picker.component.spec.ts
#	projects/igniteui-angular/src/lib/time-picker/time-picker.component.ts
@wnvko
chore(input): revert update now
48e958b
@wnvko wnvko requested a review from Lipata March 5, 2020 15:23
@wnvko wnvko requested a review from damyanpetev March 5, 2020 15:23
@wnvko wnvko added the ❌ status: awaiting-test PRs awaiting manual verification label Mar 5, 2020
@jackofdiamond5 jackofdiamond5 self-assigned this Mar 6, 2020
@jackofdiamond5 jackofdiamond5 added 💥 status: in-test PRs currently being tested ✅ status: verified Applies to PRs that have passed manual verification and removed ❌ status: awaiting-test PRs awaiting manual verification 💥 status: in-test PRs currently being tested labels Mar 6, 2020
@Lipata Lipata merged commit 72ca1ae into 8.2.x Mar 6, 2020
@Lipata Lipata deleted the mvenkov/handle-required-in-date-time-pickers-8.2.x branch March 6, 2020 09:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@damyanpetev damyanpetev Awaiting requested review from damyanpetev

1 more reviewer

@Lipata Lipata Lipata approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@jackofdiamond5 jackofdiamond5

Labels

🕐 time-picker 📅 date-picker squash-merge Merge PR with "Squash and Merge" option version: 8.2.x ✅ status: verified Applies to PRs that have passed manual verification

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@wnvko @Lipata @jackofdiamond5