Skip to content

Row pinning and filtering intergration #6884

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 15 commits into from
Mar 21, 2020
Merged

Row pinning and filtering intergration #6884

merged 15 commits into from
Mar 21, 2020

Conversation

MayaKirova
Copy link
Contributor

Related to #6640

Additional information (check all that apply):

  • Bug fix
  • New functionality
  • Documentation
  • Demos
  • CI/CD

Checklist:

  • All relevant tags have been applied to this PR
  • This PR includes unit tests covering all the new code
  • This PR includes API docs for newly added methods/properties
  • This PR includes feature/README.MD updates for the feature docs
  • This PR includes general feature table updates in the root README.MD
  • This PR includes CHANGELOG.MD updates for newly added functionality
  • This PR contains breaking changes
  • This PR includes ng update migrations for the breaking changes
  • This PR includes behavioral changes and the feature specification has been updated with them

@MayaKirova MayaKirova added ❌ status: awaiting-test PRs awaiting manual verification grid: general labels Mar 9, 2020
@radomirchev radomirchev mentioned this pull request Mar 9, 2020
Closed
30 tasks
@ChronosSF ChronosSF changed the base branch from mkirova/row-pinning-base to master March 18, 2020 10:34
@mddragnev
Copy link
Member

@MayaKirova I have found an issue within the editing interactions that might be fixed by this pr.
It should be tested whether is still reproducible when this pr is merged to master.
Steps to reproduce:
Open row pinning dev sample.
Add new row and pin it to the top.
Delete the row.
Observe the missalignment at the bottom of the grid.

pinning+editing

@ChronosSF ChronosSF added 💥 status: in-test PRs currently being tested grid: row-pinning and removed ❌ status: awaiting-test PRs awaiting manual verification labels Mar 20, 2020
dkamburov
dkamburov previously approved these changes Mar 20, 2020
View reviewed changes
@ChronosSF ChronosSF added ✅ status: verified Applies to PRs that have passed manual verification and removed 💥 status: in-test PRs currently being tested labels Mar 20, 2020
@ChronosSF ChronosSF requested a review from dkamburov March 20, 2020 17:31
@ChronosSF ChronosSF merged commit ab91892 into master Mar 21, 2020
@ChronosSF ChronosSF deleted the mkirova/row-pinning-filtering branch March 21, 2020 12:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dkamburov dkamburov dkamburov approved these changes

@3phase 3phase 3phase approved these changes

@ChronosSF ChronosSF Awaiting requested review from ChronosSF

@skrustev skrustev Awaiting requested review from skrustev

Assignees

@ChronosSF ChronosSF

Labels
grid: general grid: row-pinning ✅ status: verified Applies to PRs that have passed manual verification
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@MayaKirova @mddragnev @dkamburov @3phase @ChronosSF