Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(igxGrid): Row Pinning + Paging integration #6904

Merged
merged 10 commits into from
Mar 24, 2020

Conversation

mddragnev
Copy link
Member

Related #6640

Additional information (check all that apply):

  • Bug fix
  • New functionality
  • Documentation
  • Demos
  • CI/CD

Checklist:

  • All relevant tags have been applied to this PR
  • This PR includes unit tests covering all the new code
  • This PR includes API docs for newly added methods/properties
  • This PR includes feature/README.MD updates for the feature docs
  • This PR includes general feature table updates in the root README.MD
  • This PR includes CHANGELOG.MD updates for newly added functionality
  • This PR contains breaking changes
  • This PR includes ng update migrations for the breaking changes
  • This PR includes behavioral changes and the feature specification has been updated with them

@radomirchev radomirchev mentioned this pull request Mar 12, 2020
30 tasks
@ChronosSF ChronosSF changed the base branch from mkirova/row-pinning-base to master March 18, 2020 10:35
dkamburov
dkamburov previously approved these changes Mar 18, 2020
dkamburov
dkamburov previously approved these changes Mar 20, 2020
@MayaKirova MayaKirova self-assigned this Mar 20, 2020
@MayaKirova
Copy link
Contributor

@mddragnev @ChronosSF
If record is pinned initially, before rows are rendered, for example:
ngAfterViewInit() {
this.grid1.pinRow('FRANS');
}

Then the page size is incorrect.

With following settings: <igx-grid [paging]='true' [perPage]='5'

6 records are rendered.

image

@MayaKirova MayaKirova added 🛠️ status: in-development Issues and PRs with active development on them and removed ❌ status: awaiting-test PRs awaiting manual verification labels Mar 20, 2020
@MayaKirova MayaKirova added ❌ status: awaiting-test PRs awaiting manual verification and removed 🛠️ status: in-development Issues and PRs with active development on them labels Mar 23, 2020
@MayaKirova MayaKirova added 💥 status: in-test PRs currently being tested ✅ status: verified Applies to PRs that have passed manual verification and removed ❌ status: awaiting-test PRs awaiting manual verification labels Mar 23, 2020
@MayaKirova MayaKirova removed the 💥 status: in-test PRs currently being tested label Mar 23, 2020
@ChronosSF ChronosSF requested a review from dkamburov March 23, 2020 15:16
@ChronosSF ChronosSF merged commit 2cddb59 into master Mar 24, 2020
@ChronosSF ChronosSF deleted the mdragnev/row-pinning-paging branch March 24, 2020 09:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants