-
Notifications
You must be signed in to change notification settings - Fork 160
Row pinning and search integration #6919
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
@ChronosSF @VMihalkov filteredSortedData is not correct when row is pinned initially (for example on afterViewInit) since the pinnedRows collection is not available yet. This can be amended by checking the _pinnedRecordIDs collection instead or using the hasPinnedRecords getter). |
@MayaKirova I tested with RowPinningPosition.Bottom and again the unpinned collection is always going first through the sort pipe, so the order seems to be correct. It works with both Top and Bottom row pinning. I only replaced pinnedRows with _pinnedRecordIDs. |
@VMihalkov When row is pinned to bottom it actually becomes the last row in the grid, not the first. This is reflected in the row's index. So when findNext is used activation should move to through the unpinned row first, before reaching the pinned row. Currently it moves first to the pinned row, which is incorrect. For example, if findNext('a') is called and RowPinningPosition.Bottom is used: Should activate "Ana", not 'Alfred'. |
…m/IgniteUI/igniteui-angular into vmihalkov/search-with-row-pinning
Related to #6640
Additional information (check all that apply):
Checklist:
feature/README.MD
updates for the feature docsREADME.MD
CHANGELOG.MD
updates for newly added functionalityng update
migrations for the breaking changes