Skip to content

Row pinning and search integration #6919

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 13 commits into from
Mar 25, 2020
Merged

Conversation

VMihalkov
Copy link
Contributor

Related to #6640

Additional information (check all that apply):

  • Bug fix
  • New functionality
  • Documentation
  • Demos
  • CI/CD

Checklist:

  • All relevant tags have been applied to this PR
  • This PR includes unit tests covering all the new code
  • This PR includes API docs for newly added methods/properties
  • This PR includes feature/README.MD updates for the feature docs
  • This PR includes general feature table updates in the root README.MD
  • This PR includes CHANGELOG.MD updates for newly added functionality
  • This PR contains breaking changes
  • This PR includes ng update migrations for the breaking changes
  • This PR includes behavioral changes and the feature specification has been updated with them

@VMihalkov VMihalkov added ❌ status: awaiting-test PRs awaiting manual verification grid: general labels Mar 17, 2020
@ChronosSF ChronosSF changed the base branch from mkirova/row-pinning-base to master March 18, 2020 10:36
dkamburov
dkamburov previously approved these changes Mar 18, 2020
@ChronosSF ChronosSF requested a review from dkamburov March 20, 2020 13:30
@MayaKirova MayaKirova added 💥 status: in-test PRs currently being tested and removed ❌ status: awaiting-test PRs awaiting manual verification labels Mar 20, 2020
@MayaKirova MayaKirova self-assigned this Mar 20, 2020
@MayaKirova
Copy link
Contributor

@ChronosSF @VMihalkov filteredSortedData is not correct when row is pinned initially (for example on afterViewInit) since the pinnedRows collection is not available yet. This can be amended by checking the _pinnedRecordIDs collection instead or using the hasPinnedRecords getter).
Order is also incorrect if row position is set to RowPinningPosition.Bottom as the pinned rows are always added first in the collection.

@MayaKirova MayaKirova added 🛠️ status: in-development Issues and PRs with active development on them and removed 💥 status: in-test PRs currently being tested labels Mar 20, 2020
@VMihalkov
Copy link
Contributor Author

@ChronosSF @VMihalkov filteredSortedData is not correct when row is pinned initially (for example on afterViewInit) since the pinnedRows collection is not available yet. This can be amended by checking the _pinnedRecordIDs collection instead or using the hasPinnedRecords getter).
Order is also incorrect if row position is set to RowPinningPosition.Bottom as the pinned rows are always added first in the collection.

@MayaKirova I tested with RowPinningPosition.Bottom and again the unpinned collection is always going first through the sort pipe, so the order seems to be correct. It works with both Top and Bottom row pinning. I only replaced pinnedRows with _pinnedRecordIDs.

@MayaKirova
Copy link
Contributor

@VMihalkov When row is pinned to bottom it actually becomes the last row in the grid, not the first. This is reflected in the row's index. So when findNext is used activation should move to through the unpinned row first, before reaching the pinned row. Currently it moves first to the pinned row, which is incorrect.

For example, if findNext('a') is called and RowPinningPosition.Bottom is used:
image

Should activate "Ana", not 'Alfred'.

@MayaKirova MayaKirova added 💥 status: in-test PRs currently being tested ✅ status: verified Applies to PRs that have passed manual verification and removed 🛠️ status: in-development Issues and PRs with active development on them 💥 status: in-test PRs currently being tested labels Mar 23, 2020
dkamburov
dkamburov previously approved these changes Mar 24, 2020
@ChronosSF ChronosSF self-requested a review March 24, 2020 16:38
@ChronosSF ChronosSF merged commit 4bf90ac into master Mar 25, 2020
@ChronosSF ChronosSF deleted the vmihalkov/search-with-row-pinning branch March 25, 2020 08:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
grid: general grid: row-pinning ✅ status: verified Applies to PRs that have passed manual verification
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants