Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DateTime Editor implementation #6923

Merged
merged 35 commits into from
Apr 16, 2020
Merged

DateTime Editor implementation #6923

merged 35 commits into from
Apr 16, 2020

Conversation

jackofdiamond5
Copy link
Member

@jackofdiamond5 jackofdiamond5 commented Mar 18, 2020 •
edited
Loading

Closes #6271

Additional information (check all that apply):

  • Bug fix
  • New functionality
  • Documentation
  • Demos
  • CI/CD

Checklist:

  • All relevant tags have been applied to this PR
  • This PR includes unit tests covering all the new code
  • This PR includes API docs for newly added methods/properties
  • This PR includes feature/README.MD updates for the feature docs
  • This PR includes general feature table updates in the root README.MD
  • This PR includes CHANGELOG.MD updates for newly added functionality
  • This PR contains breaking changes
  • This PR includes ng update migrations for the breaking changes
  • This PR includes behavioral changes and the feature specification has been updated with them

@jackofdiamond5 jackofdiamond5 force-pushed the bpenkov/date-time-editor branch 3 times, most recently from 72ba928 to d40deb2 Compare March 23, 2020 09:10
@jackofdiamond5 jackofdiamond5 marked this pull request as ready for review March 23, 2020 09:12
@jackofdiamond5 jackofdiamond5 added ❌ status: awaiting-test PRs awaiting manual verification and removed 🛠️ status: in-development Issues and PRs with active development on them labels Mar 23, 2020
@jackofdiamond5 jackofdiamond5 force-pushed the bpenkov/date-time-editor branch from 964eb1a to 889ace2 Compare March 27, 2020 09:20
@jackofdiamond5 jackofdiamond5 force-pushed the bpenkov/date-time-editor branch from ab0315c to 925474c Compare March 31, 2020 07:04
damyanpetev
damyanpetev reviewed Apr 9, 2020
View reviewed changes
@jackofdiamond5 jackofdiamond5 force-pushed the bpenkov/date-time-editor branch from 17293f0 to 06948b4 Compare April 14, 2020 14:27
@dafo dafo added 💥 status: in-test PRs currently being tested and removed ❌ status: awaiting-test PRs awaiting manual verification labels Apr 15, 2020
jackofdiamond5 and others added 15 commits April 15, 2020 16:51
@jackofdiamond5
refactor(date-time-editor): change validationFail to validationFailed
20900b2 
- prevent validationFailed from emitting on empty input
@PlamenaMiteva
test(date-editor): fix failing tests #6271
58b840b
@PlamenaMiteva
Merge branch 'bpenkov/date-time-editor' of https://github.com/IgniteU…
03d0516 
…I/igniteui-angular into PMiteva/date-time-editor-latest

# Conflicts:
#	projects/igniteui-angular/src/lib/directives/date-time-editor/date-time-editor.directive.spec.ts
@PlamenaMiteva
test(date-editor): remove fdescribe #6271
6ed831c
@PlamenaMiteva
test(date-editor): remove fdescribe #6271
a80b963
@PlamenaMiteva
Merge branch 'bpenkov/date-time-editor' of https://github.com/IgniteU…
ac4c2cc 
…I/igniteui-angular into PMiteva/date-time-editor-latest
@Lipata
Merge branch 'master' into bpenkov/date-time-editor
424808d
@Lipata
Merge branch 'master' into bpenkov/date-time-editor
8801bf7
@Lipata
Merge branch 'master' into bpenkov/date-time-editor
10d7306
@PlamenaMiteva
test(date-editor): refactor date formats #6271
ab342ec
@PlamenaMiteva
Merge branch 'bpenkov/date-time-editor' of https://github.com/IgniteU…
e3d44e4 
…I/igniteui-angular into PMiteva/date-time-editor-latest
@jackofdiamond5
refactor(date-editor): update events, display format for IE, spin met…
448e967 
…hods
@damyanpetev
refactor(date-editor): parse format and tests, rename parse value
79ef0bd
@Lipata
Merge branch 'master' into bpenkov/date-time-editor
1d3f6cc
@jackofdiamond5
refactor(date-editor): fix failing tests, promptChars
b759cd3
damyanpetev
damyanpetev approved these changes Apr 16, 2020
View reviewed changes
Copy link
Member

@damyanpetev damyanpetev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There's minor cleanup to be done still, but this should be good enough and well covered for base version.

@dafo dafo added ✅ status: verified Applies to PRs that have passed manual verification and removed 💥 status: in-test PRs currently being tested labels Apr 16, 2020
@Lipata Lipata merged commit 31abc2e into master Apr 16, 2020
@Lipata Lipata deleted the bpenkov/date-time-editor branch April 16, 2020 12:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Lipata Lipata Lipata approved these changes

@damyanpetev damyanpetev damyanpetev approved these changes

Assignees

@dafo dafo

Labels
📅 date-time-editor version: 9.1.x ✅ status: verified Applies to PRs that have passed manual verification
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Separate date and time editing functionalities from igxDatePicker and igxTimePicker into a new directive
6 participants
@jackofdiamond5 @Lipata @damyanpetev @dafo @IvayloG @PlamenaMiteva