Skip to content

feat(select): Add igxHint support #5584 #7487

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 14 commits into from
Jun 19, 2020
Merged

feat(select): Add igxHint support #5584 #7487

merged 14 commits into from
Jun 19, 2020

Conversation

IvayloG
Copy link
Contributor

@IvayloG IvayloG commented Jun 4, 2020 •
edited
Loading

Closes #5584

Additional information (check all that apply):

  • Bug fix
  • New functionality
  • Documentation
  • Demos
  • CI/CD

Checklist:

  • All relevant tags have been applied to this PR
  • This PR includes unit tests covering all the new code (test guidelines)
  • This PR includes API docs for newly added methods/properties (api docs guidelines)
  • This PR includes feature/README.MD updates for the feature docs
  • This PR includes general feature table updates in the root README.MD
  • This PR includes CHANGELOG.MD updates for newly added functionality
  • This PR contains breaking changes
  • This PR includes ng update migrations for the breaking changes (migrations guidelines)
  • This PR includes behavioral changes and the feature specification has been updated with them

@IvayloG IvayloG added 📈 enhancement ❌ status: awaiting-test PRs awaiting manual verification select Select component version: 9.2.x labels Jun 4, 2020
@IvayloG IvayloG requested review from Lipata and damyanpetev June 4, 2020 14:28
This was referenced Jun 4, 2020
Closed
Merged
Closed
Merged
@Lipata Lipata requested a review from wnvko June 5, 2020 20:26
@IvayloG IvayloG requested a review from wnvko June 10, 2020 08:01
wnvko
wnvko previously approved these changes Jun 10, 2020
View reviewed changes
@valadzhov valadzhov added 💥 status: in-test PRs currently being tested ✅ status: verified Applies to PRs that have passed manual verification and removed ❌ status: awaiting-test PRs awaiting manual verification 💥 status: in-test PRs currently being tested labels Jun 11, 2020
Lipata
Lipata previously approved these changes Jun 16, 2020
View reviewed changes
@IvayloG IvayloG requested review from damyanpetev, Lipata and wnvko June 18, 2020 12:31
Lipata
Lipata previously approved these changes Jun 18, 2020
View reviewed changes
@Lipata Lipata added 💥 status: in-test PRs currently being tested and removed ❌ do not merge ✅ status: verified Applies to PRs that have passed manual verification labels Jun 18, 2020
@valadzhov valadzhov added ✅ status: verified Applies to PRs that have passed manual verification and removed 💥 status: in-test PRs currently being tested labels Jun 18, 2020
damyanpetev
damyanpetev previously approved these changes Jun 19, 2020
View reviewed changes
@damyanpetev damyanpetev added the squash-merge Merge PR with "Squash and Merge" option label Jun 19, 2020
@damyanpetev damyanpetev changed the title Add igxHint support feat(select): Add igxHint support #5584 Jun 19, 2020
@Lipata Lipata requested review from damyanpetev and Lipata June 19, 2020 11:14
@Lipata Lipata merged commit 473a31a into master Jun 19, 2020
@Lipata Lipata deleted the iganchev/select-implement-hint branch June 19, 2020 12:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Lipata Lipata Lipata approved these changes

@damyanpetev damyanpetev damyanpetev approved these changes

@wnvko wnvko wnvko approved these changes

Assignees

@valadzhov valadzhov

Labels
📈 enhancement select Select component squash-merge Merge PR with "Squash and Merge" option version: 10.0.x ✅ status: verified Applies to PRs that have passed manual verification
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[igxSelect] Add igxHint support
7 participants
@IvayloG @Lipata @damyanpetev @wnvko @kdinev @valadzhov @rkaraivanov