Update calendar with two filled in inputs #7614
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jackofdiamond5
added
❌ status: awaiting-test
PlamenaMiteva
previously approved these changes
Jun 17, 2020
PlamenaMiteva
added
💥 status: in-test
wnvko
requested changes
Jun 17, 2020
projects/igniteui-angular/src/lib/date-range-picker/date-range-picker.component.ts
Show resolved
Hide resolved
projects/igniteui-angular/src/lib/date-range-picker/date-range-picker.component.ts
Outdated
Show resolved
Hide resolved
projects/igniteui-angular/src/lib/date-range-picker/date-range-picker.component.ts
Show resolved
Hide resolved
PlamenaMiteva
added
✅ status: verified
jackofdiamond5
force-pushed
the
bpenkov/date-range-updating-calendar
branch
3 times, most recently
from
40378be to
3f4b834
Compare
wnvko
previously approved these changes
Jun 19, 2020
Contributor
wnvko
left a comment
wnvko
left a comment
There was a problem hiding this comment.
Approving this with some notes:
- I still believe we should emit
onOpeningbefore manipulating thevalue; - I do not like swapping of the values in case
start>end;
…e filled in - set validity based on inputs' value(s) - ensure selected range is within min/max (if any) - swap start & end if start is greater
jackofdiamond5
force-pushed
the
bpenkov/date-range-updating-calendar
branch
from
3f4b834 to
e3631eb
Compare
PlamenaMiteva
approved these changes
Jun 19, 2020
wnvko
approved these changes
Jun 22, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #7593
Additional information (check all that apply):
Checklist:
feature/README.MDupdates for the feature docsREADME.MDCHANGELOG.MDupdates for newly added functionalityng updatemigrations for the breaking changes (migrations guidelines)