Skip to content

Update calendar with two filled in inputs - master #7640

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 22, 2020
Merged

Update calendar with two filled in inputs - master #7640

merged 1 commit into from
Jun 22, 2020

Conversation

jackofdiamond5
Copy link
Member

@jackofdiamond5 jackofdiamond5 commented Jun 22, 2020 •
edited
Loading

Closes #7593

Additional information (check all that apply):

  • Bug fix
  • New functionality
  • Documentation
  • Demos
  • CI/CD

Checklist:

  • All relevant tags have been applied to this PR
  • This PR includes unit tests covering all the new code (test guidelines)
  • This PR includes API docs for newly added methods/properties (api docs guidelines)
  • This PR includes feature/README.MD updates for the feature docs
  • This PR includes general feature table updates in the root README.MD
  • This PR includes CHANGELOG.MD updates for newly added functionality
  • This PR contains breaking changes
  • This PR includes ng update migrations for the breaking changes (migrations guidelines)
  • This PR includes behavioral changes and the feature specification has been updated with them

@jackofdiamond5
refactor(date-range-picker): update calendar only when both inputs ar…
a6e8dab 
…e filled in

- set validity based on inputs' value(s)
- ensure selected range is within min/max (if any)
- swap start & end if start is greater
@jackofdiamond5 jackofdiamond5 changed the title refactor(date-range-picker): update calendar only when both inputs ar… Update calendar with two filled in inputs - master Jun 22, 2020
wnvko
wnvko approved these changes Jun 22, 2020
View reviewed changes
Copy link
Contributor

@wnvko wnvko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving this with some notes:

  • I still believe we should emit onOpening before manipulating the value;
  • I do not like swapping of the values in case start > end;

@PlamenaMiteva PlamenaMiteva added 💥 status: in-test PRs currently being tested ✅ status: verified Applies to PRs that have passed manual verification and removed ❌ status: awaiting-test PRs awaiting manual verification version: 10.0.x 💥 status: in-test PRs currently being tested labels Jun 22, 2020
@Lipata Lipata merged commit e2568d4 into master Jun 22, 2020
@Lipata Lipata deleted the bpenkov/date-range-updating-calendar-master branch June 22, 2020 08:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wnvko wnvko wnvko approved these changes

@PlamenaMiteva PlamenaMiteva PlamenaMiteva approved these changes

Assignees

@PlamenaMiteva PlamenaMiteva

Labels
📅 date-range-picker version: 10.0.x ✅ status: verified Applies to PRs that have passed manual verification
Projects
None yet
Milestone
No milestone
4 participants
@jackofdiamond5 @wnvko @PlamenaMiteva @Lipata