Skip to content

Add support for Column Resizing and AutoSizing of % widths #7662

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 10 commits into from
Jul 1, 2020
Merged

Add support for Column Resizing and AutoSizing of % widths #7662

merged 10 commits into from
Jul 1, 2020

Conversation

MayaKirova
Copy link
Contributor

@MayaKirova MayaKirova commented Jun 23, 2020 •
edited
Loading

Related to #5486

To do:

  • Add automation for new scenario.

Additional information (check all that apply):

  • Bug fix
  • New functionality
  • Documentation
  • Demos
  • CI/CD

Checklist:

  • All relevant tags have been applied to this PR
  • This PR includes unit tests covering all the new code (test guidelines)
  • This PR includes API docs for newly added methods/properties (api docs guidelines)
  • This PR includes feature/README.MD updates for the feature docs
  • This PR includes general feature table updates in the root README.MD
  • This PR includes CHANGELOG.MD updates for newly added functionality
  • This PR contains breaking changes
  • This PR includes ng update migrations for the breaking changes (migrations guidelines)
  • This PR includes behavioral changes and the feature specification has been updated with them

@MayaKirova MayaKirova added the ❌ status: awaiting-test PRs awaiting manual verification label Jun 23, 2020
@MayaKirova MayaKirova requested a review from ChronosSF June 23, 2020 14:14
@MayaKirova MayaKirova marked this pull request as ready for review June 23, 2020 16:25
@mpavlinov mpavlinov mentioned this pull request Jun 23, 2020
Closed
4 tasks
@MayaKirova MayaKirova requested review from skrustev and dkamburov June 23, 2020 16:32
@skrustev skrustev added 💥 status: in-test PRs currently being tested and removed ❌ status: awaiting-test PRs awaiting manual verification labels Jun 25, 2020
@skrustev
Copy link
Member

skrustev commented Jun 25, 2020 •
edited by MayaKirova
Loading

  • - When resizing in small amount columns with width in percentage the header does not resize, but the cells do resize and a misalignment between the header and cells appear.

headers-percentage

@MayaKirova
Copy link
Contributor Author

@skrustev Issue should be fixed now. Please re-test.

@skrustev skrustev added ✅ status: verified Applies to PRs that have passed manual verification and removed 💥 status: in-test PRs currently being tested labels Jun 30, 2020
@ChronosSF ChronosSF merged commit fdb6355 into master Jul 1, 2020
@ChronosSF ChronosSF deleted the mkirova/resizing-percentage-width branch July 1, 2020 10:58
@MayaKirova MayaKirova mentioned this pull request Nov 10, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ChronosSF ChronosSF ChronosSF approved these changes

@skrustev skrustev Awaiting requested review from skrustev

@dkamburov dkamburov Awaiting requested review from dkamburov

Assignees

@ChronosSF ChronosSF

@skrustev skrustev

Labels
grid: general grid: resizing version: 10.1.x ✅ status: verified Applies to PRs that have passed manual verification
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@MayaKirova @skrustev @ChronosSF @kdinev