Skip to content

Make selectedRows an @Input #7717

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 13 commits into from
Jul 28, 2020
Merged

Make selectedRows an @Input #7717

merged 13 commits into from
Jul 28, 2020

Conversation

jackofdiamond5
Copy link
Member

@jackofdiamond5 jackofdiamond5 commented Jun 30, 2020 •
edited
Loading

Closes #6653 #6974

Additional information (check all that apply):

  • Bug fix
  • New functionality
  • Documentation
  • Demos
  • CI/CD

Checklist:

  • All relevant tags have been applied to this PR
  • This PR includes unit tests covering all the new code (test guidelines)
  • This PR includes API docs for newly added methods/properties (api docs guidelines)
  • This PR includes feature/README.MD updates for the feature docs
  • This PR includes general feature table updates in the root README.MD
  • This PR includes CHANGELOG.MD updates for newly added functionality
  • This PR contains breaking changes
  • This PR includes ng update migrations for the breaking changes (migrations guidelines)
  • This PR includes behavioral changes and the feature specification has been updated with them

@jackofdiamond5 jackofdiamond5 force-pushed the bpenkov/grid-selectedRows-input branch 2 times, most recently from 3259764 to c7dc04b Compare July 4, 2020 10:26
@jackofdiamond5 jackofdiamond5 force-pushed the bpenkov/grid-selectedRows-input branch from c7dc04b to 6da1d4b Compare July 6, 2020 12:28
@jackofdiamond5 jackofdiamond5 marked this pull request as ready for review July 7, 2020 13:23
@jackofdiamond5 jackofdiamond5 requested a review from IvayloG July 7, 2020 13:24
@jackofdiamond5 jackofdiamond5 added ❌ status: awaiting-test PRs awaiting manual verification and removed 🛠️ status: in-development Issues and PRs with active development on them labels Jul 7, 2020
@Lipata Lipata removed the request for review from IvayloG July 8, 2020 05:56
@jackofdiamond5 jackofdiamond5 requested a review from Lipata July 8, 2020 11:59
@valadzhov valadzhov added 💥 status: in-test PRs currently being tested and removed ❌ status: awaiting-test PRs awaiting manual verification labels Jul 22, 2020
@valadzhov
Copy link
Collaborator

Tested the PR and also fixed some minor typos and a deleteSelectedRow() method which wasn't working in the sample.

@valadzhov valadzhov added ✅ status: verified Applies to PRs that have passed manual verification and removed 💥 status: in-test PRs currently being tested labels Jul 22, 2020
@Lipata Lipata merged commit dedf987 into master Jul 28, 2020
@Lipata Lipata deleted the bpenkov/grid-selectedRows-input branch July 28, 2020 14:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Lipata Lipata Lipata approved these changes

Assignees

@valadzhov valadzhov

Labels
‼️ breaking-change grid: general grid: row-selection version: 10.1.x ✅ status: verified Applies to PRs that have passed manual verification
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

igx-grid - pre-select rows
4 participants
@jackofdiamond5 @valadzhov @Lipata @kdinev