Skip to content

feat(grid-esf): make excel style filtering work like in excel #8193

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 32 commits into from
Oct 8, 2020
Merged

feat(grid-esf): make excel style filtering work like in excel #8193

merged 32 commits into from
Oct 8, 2020

Conversation

onlyexeption
Copy link
Contributor

@onlyexeption onlyexeption commented Sep 23, 2020 •
edited by DiyanDimitrov
Loading

Closes #5813
Closes #6617
Closes #5812

Additional information (check all that apply):

  • Bug fix
  • New functionality
  • Documentation
  • Demos
  • CI/CD

Checklist:

  • All relevant tags have been applied to this PR
  • This PR includes unit tests covering all the new code (test guidelines)
  • This PR includes API docs for newly added methods/properties (api docs guidelines)
  • This PR includes feature/README.MD updates for the feature docs
  • This PR includes general feature table updates in the root README.MD
  • This PR includes CHANGELOG.MD updates for newly added functionality
  • This PR contains breaking changes
  • This PR includes ng update migrations for the breaking changes (migrations guidelines)
  • This PR includes behavioral changes and the feature specification has been updated with them

@DiyanDimitrov DiyanDimitrov self-requested a review September 29, 2020 14:57
@DiyanDimitrov DiyanDimitrov marked this pull request as ready for review September 30, 2020 08:48
@DiyanDimitrov DiyanDimitrov added the ❌ status: awaiting-test PRs awaiting manual verification label Sep 30, 2020
DiyanDimitrov
DiyanDimitrov suggested changes Sep 30, 2020
View reviewed changes
Copy link
Contributor

@DiyanDimitrov DiyanDimitrov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add the feature to the changelog.

DiyanDimitrov
DiyanDimitrov suggested changes Oct 1, 2020
View reviewed changes
onlyexeption and others added 2 commits October 1, 2020 16:00
@onlyexeption @DiyanDimitrov
Update CHANGELOG.md
43eff82 
Co-authored-by: Diyan Dimitrov <[email protected]>
@onlyexeption @DiyanDimitrov
Update CHANGELOG.md
2f8e4a3 
Co-authored-by: Diyan Dimitrov <[email protected]>
DiyanDimitrov
DiyanDimitrov previously approved these changes Oct 5, 2020
View reviewed changes
@DiyanDimitrov DiyanDimitrov self-requested a review October 6, 2020 15:31
DiyanDimitrov
DiyanDimitrov previously approved these changes Oct 6, 2020
View reviewed changes
@igdmdimitrov igdmdimitrov added ✅ status: verified Applies to PRs that have passed manual verification and removed ❌ status: awaiting-test PRs awaiting manual verification labels Oct 8, 2020
@DiyanDimitrov DiyanDimitrov self-requested a review October 8, 2020 07:44
DiyanDimitrov
DiyanDimitrov previously approved these changes Oct 8, 2020
View reviewed changes
@DiyanDimitrov DiyanDimitrov self-requested a review October 8, 2020 08:13
@DiyanDimitrov DiyanDimitrov merged commit fe80320 into master Oct 8, 2020
@DiyanDimitrov DiyanDimitrov deleted the ibarakov/fix-5813-10.2.x branch October 8, 2020 09:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DiyanDimitrov DiyanDimitrov DiyanDimitrov approved these changes

@igdmdimitrov igdmdimitrov Awaiting requested review from igdmdimitrov

Assignees

@igdmdimitrov igdmdimitrov

Labels
grid: excel-style-filtering grid: general version: 10.2.x ✅ status: verified Applies to PRs that have passed manual verification
Projects
None yet
Milestone
No milestone
3 participants
@onlyexeption @DiyanDimitrov @igdmdimitrov