Skip to content

Calendar keyboard navigation improvements #8314

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 23 commits into from
Oct 9, 2020
Merged

Calendar keyboard navigation improvements #8314

merged 23 commits into from
Oct 9, 2020

Conversation

ddincheva
Copy link
Contributor

Closes #6275

Additional information (check all that apply):

  • Bug fix
  • New functionality
  • Documentation
  • Demos
  • CI/CD

Checklist:

  • All relevant tags have been applied to this PR
  • This PR includes unit tests covering all the new code (test guidelines)
  • This PR includes API docs for newly added methods/properties (api docs guidelines)
  • This PR includes feature/README.MD updates for the feature docs
  • This PR includes general feature table updates in the root README.MD
  • This PR includes CHANGELOG.MD updates for newly added functionality
  • This PR contains breaking changes
  • This PR includes ng update migrations for the breaking changes (migrations guidelines)
  • This PR includes behavioral changes and the feature specification has been updated with them

ddincheva added 14 commits October 1, 2020 17:24
@ddincheva
feat(IgxMonthView): add one tab stop in the month view #6275
9c93344
@ddincheva
feat(IgxYearsView): add tabIndex to years view elements #6275
aadcf0a
@ddincheva
chore(*): remove tabIndex from day-item component
ab5ada7
@ddincheva
feat(*): reset tab Index when navigationg out of the calendar #6275
5a5ddfe
@ddincheva
Merge branch 'master' of https://github.com/IgniteUI/igniteui-angular …
3be5074 
…into ddincheva/calendarKB
@ddincheva
feat(DateItem): update activeDate on focus #6275
345fb9d
@ddincheva
feat(Calendar): recalc activeDate when views are changed #6275
93a2aff
@ddincheva
chore(*): remove leftover code
7084415
@ddincheva
chore(*): return nav service to initial state
57c73ca
@ddincheva
feat(Calendar): remove tabIndex from the component itself #6275
9bf6560
@ddincheva
Merge branch 'master' of https://github.com/IgniteUI/igniteui-angular …
cc749c4 
…into ddincheva/calendarKB
@ddincheva
chore(*): clear up some leftover logic
4c66da6
@ddincheva
test(IgxCalendar): verify that tabIndex is applied correctly #6275
35f3787
@ddincheva
chore(*): fix linting errors
ea169d1
@zdrawku zdrawku added the 💥 status: in-test PRs currently being tested label Oct 8, 2020
@zdrawku zdrawku self-requested a review October 8, 2020 13:38
@zdrawku zdrawku self-assigned this Oct 8, 2020
@zdrawku zdrawku marked this pull request as ready for review October 8, 2020 13:38
@zdrawku zdrawku removed the 💥 status: in-test PRs currently being tested label Oct 9, 2020
@zdrawku zdrawku added the ✅ status: verified Applies to PRs that have passed manual verification label Oct 9, 2020
@zdrawku zdrawku merged commit 042e102 into master Oct 9, 2020
@zdrawku zdrawku deleted the ddincheva/calendarKB branch October 9, 2020 15:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zdrawku zdrawku zdrawku approved these changes

Assignees

@zdrawku zdrawku

Labels
version: 10.2.x ✅ status: verified Applies to PRs that have passed manual verification
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Calendar keyboard navigation accessibility
2 participants
@ddincheva @zdrawku