Skip to content

Mpopov/calendar accessibility #8335

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 31 commits into from
Closed

Conversation

desig9stein
Copy link
Contributor

@desig9stein desig9stein commented Oct 9, 2020

Closes #6272

Additional information (check all that apply):

  • Bug fix
  • New functionality
  • Documentation
  • Demos
  • CI/CD

Checklist:

  • All relevant tags have been applied to this PR
  • This PR includes unit tests covering all the new code (test guidelines)
  • This PR includes API docs for newly added methods/properties (api docs guidelines)
  • This PR includes feature/README.MD updates for the feature docs
  • This PR includes general feature table updates in the root README.MD
  • This PR includes CHANGELOG.MD updates for newly added functionality
  • This PR contains breaking changes
  • This PR includes ng update migrations for the breaking changes (migrations guidelines)
  • This PR includes behavioral changes and the feature specification has been updated with them

MPopov added 10 commits September 30, 2020 15:12
…niteui-angular into mpopov/calendar-accessibility

� Conflicts:
�	projects/igniteui-angular/src/lib/calendar/calendar.component.html
�	projects/igniteui-angular/src/lib/calendar/months-view/months-view.component.html
…niteui-angular into mpopov/calendar-accessibility

� Conflicts:
�	projects/igniteui-angular/src/lib/calendar/calendar.component.html
�	projects/igniteui-angular/src/lib/calendar/calendar.component.ts
@desig9stein desig9stein marked this pull request as ready for review October 13, 2020 13:56
@ChronosSF ChronosSF changed the base branch from master to 10.2.x October 20, 2020 13:53
@desig9stein desig9stein added the ❌ status: awaiting-test PRs awaiting manual verification label Oct 26, 2020
@ddincheva ddincheva added 💥 status: in-test PRs currently being tested and removed ❌ status: awaiting-test PRs awaiting manual verification labels Nov 4, 2020
@ddincheva
Copy link
Contributor

I managed to test this PR using Chrome Vox extension tool and NVDA application. There are small differences between the two narrators but overall all elements and applied changes are read correctly. Good job!

@ddincheva ddincheva added ✅ status: verified Applies to PRs that have passed manual verification and removed 💥 status: in-test PRs currently being tested labels Nov 4, 2020
@simeonoff simeonoff changed the base branch from 10.2.x to master November 5, 2020 09:33
@simeonoff simeonoff changed the base branch from master to 10.2.x November 5, 2020 09:34
@desig9stein desig9stein closed this Nov 5, 2020
@desig9stein desig9stein deleted the mpopov/calendar-accessibility branch November 9, 2020 08:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
aria-support 📆 calendar version: 11.0.x ✅ status: verified Applies to PRs that have passed manual verification
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Calendar ARIA
5 participants