Fix animations when content is flipped #8337
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wnvko
added
❌ status: awaiting-test
…eUI/igniteui-angular into mvenkov/use-correct-animation-10.2
ViktorSlavov
suggested changes
Oct 12, 2020
wnvko
force-pushed
the
mvenkov/use-correct-animation-10.2
branch
from
96631dd to
2e7dac9
Compare
simeonoff
previously approved these changes
Oct 12, 2020
ViktorSlavov
previously approved these changes
Oct 13, 2020
PlamenaMiteva
added
💥 status: in-test
ChronosSF
dismissed stale reviews from ViktorSlavov and simeonoff
The base branch was changed.
ViktorSlavov
approved these changes
Oct 21, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New util function is introduced -
oppositeAnimationResolver. Passing an animation to this function returns opposite animation if one exists. By the help of this function, when content shown in overlay is flipped by the auto position strategy, we are changing and provided animations.Closes #8238
Additional information (check all that apply):
Checklist:
feature/README.MDupdates for the feature docsREADME.MDCHANGELOG.MDupdates for newly added functionalityng updatemigrations for the breaking changes (migrations guidelines)