Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Excel style filtering header icon template #8511

Merged
merged 9 commits into from
Nov 5, 2020
Merged

Add Excel style filtering header icon template #8511

merged 9 commits into from
Nov 5, 2020

Conversation

onlyexeption
Copy link
Contributor

Closes #7878

Additional information (check all that apply):

  • Bug fix
  • New functionality
  • Documentation
  • Demos
  • CI/CD

Checklist:

  • All relevant tags have been applied to this PR
  • This PR includes unit tests covering all the new code (test guidelines)
  • This PR includes API docs for newly added methods/properties (api docs guidelines)
  • This PR includes feature/README.MD updates for the feature docs
  • This PR includes general feature table updates in the root README.MD
  • This PR includes CHANGELOG.MD updates for newly added functionality
  • This PR contains breaking changes
  • This PR includes ng update migrations for the breaking changes (migrations guidelines)
  • This PR includes behavioral changes and the feature specification has been updated with them

@DiyanDimitrov DiyanDimitrov changed the title Ibarakov/fix 7878 master Add Excel style filtering header icon template Nov 3, 2020
DiyanDimitrov
DiyanDimitrov reviewed Nov 3, 2020
View reviewed changes
@onlyexeption @DiyanDimitrov
Update CHANGELOG.md
512eb14 
Co-authored-by: Diyan Dimitrov <[email protected]>
@DiyanDimitrov
Copy link
Contributor

The igxExcelStyleHeaderIcon directive does not work for hierarchical grid's row islands.

@DiyanDimitrov DiyanDimitrov self-assigned this Nov 4, 2020
@DiyanDimitrov DiyanDimitrov added ✅ status: verified Applies to PRs that have passed manual verification and removed ❌ status: awaiting-test PRs awaiting manual verification labels Nov 4, 2020
@kdinev kdinev merged commit 966abea into master Nov 5, 2020
@kdinev kdinev deleted the ibarakov/fix-7878-master branch November 5, 2020 15:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@simeonoff simeonoff simeonoff approved these changes

@DiyanDimitrov DiyanDimitrov DiyanDimitrov approved these changes

Assignees

@DiyanDimitrov DiyanDimitrov

Labels
grid: excel-style-filtering grid: general version: 11.0.x ✅ status: verified Applies to PRs that have passed manual verification
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Make the ESF header icon templatable
4 participants
@onlyexeption @DiyanDimitrov @simeonoff @kdinev