-
Notifications
You must be signed in to change notification settings - Fork 160
feat(tree-grid): add cascading row selection #8040 #8772
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from 70 commits
Commits
Show all changes
75 commits
Select commit
Hold shift + click to select a range
db6f321
feat(grid): add new grid rowSelection mode
2968470
chore(*): added initial multipleCascade selection logic
0e016ad
Merge branch 'master' of https://github.com/IgniteUI/igniteui-angular…
e9e6bfc
chore(*): fix lint issues
32d37ef
Merge branch 'master' of https://github.com/IgniteUI/igniteui-angular…
3bd7aab
chore(*): fix should bind selectedRows properly test
95ad14f
chore(*): fix hierarchical-grid test
977b5f5
chore(*): fix filtering issues
674ef86
Merge branch 'master' of https://github.com/IgniteUI/igniteui-angular…
MonikaKirkova dd98bd7
feat(grid): add test scenarios
MonikaKirkova d96e716
Merge branch 'master' of https://github.com/IgniteUI/igniteui-angular…
4019aad
Merge branch 'mevtimov/feat-8040' of https://github.com/IgniteUI/igni…
417dcae
feat(grid): add navigation tests
99f2d40
chore(*): fix lint issues
28bfed6
Merge branch 'master' of https://github.com/IgniteUI/igniteui-angular…
a4afd48
feat(grid): add row adding tests
c9d44ea
feat(grid): add row deleting tests
18a44f3
Merge branch 'master' of https://github.com/IgniteUI/igniteui-angular…
17b31e6
chore(*): fix merge conflicts
f90edfb
chore(*): fix multipleCascade selection when add row
20f7602
chore(*): modify row adding test
c397269
Merge branch 'master' of https://github.com/IgniteUI/igniteui-angular…
8d86434
chore(*): added filtering tests
8ffe4e1
chore(*): added batch updating tests
764b7e5
chore(*): modified batch updating test
491f958
chore(*): fixed batch updating test
93e18f5
chore(*): add more filtering tests
30ab842
chore(*): add more filtering tests
925e229
chore(*): add filtering+updating test
16f3f15
chore(*): add additional filtering + updating test
50cca84
chore(*): fix lint issues
e41f083
chore(*): fix filtering + updating tests
bdb6476
chore(*): fixed loadOnDemand when multipleCascade selection is enabled
f4ed64a
Merge branch 'master' of https://github.com/IgniteUI/igniteui-angular…
7267a88
chore(*): add test for canceling the row selection event
d022e56
chore(*): add selection service api tests
d2083b2
Merge branch 'master' into mevtimov/feat-8040
kdinev 9b418a9
chore(*): added onSelectedRowChange event tests
f1b19d6
chore(*): fix requested changes
60df17c
Merge branch 'master' of https://github.com/IgniteUI/igniteui-angular…
1a8338d
chore(*): fix preselected rows
101c98b
Merge branch 'master' of https://github.com/IgniteUI/igniteui-angular…
0037839
chore(*): fix testing issues
b8cb930
Merge branch 'master' of https://github.com/IgniteUI/igniteui-angular…
8a7fe65
chore(*): fix onActionClick event name
47f9570
Merge branch 'master' of https://github.com/IgniteUI/igniteui-angular…
3342012
chore(*): fix some of the requiested changes
9d13119
chore(*): add coments and type request changes
febffc3
chore(*): fix lint errors
4d12636
chore(*): add some requested changes
7a13546
chore(*): add requested changes for get_all_children
e777c07
chore(*): add requested changes for updateCascadeSelectionOnFilterAnd…
1590407
chore(*): modify calculateRowsNewSelectionState and dev sample
0038568
Merge branch 'master' into mevtimov/feat-8040
teodosiah 49bdee9
chore(*): fix lint errors
589ad47
chore(*): move cascade selection to tree-grid-selection service
93f6f86
Merge branch 'master' into mevtimov/feat-8040
teodosiah 0ed1197
chore(*): fix lint issues
0b64541
chore(*): fix lint errors
97bed59
Merge branch 'master' into mevtimov/feat-8040
kdinev ef23d52
chore(*): modify some tests
d959c4d
Merge branch 'mevtimov/feat-8040' of https://github.com/IgniteUI/igni…
4f96633
Merge branch 'master' into mevtimov/feat-8040
DiyanDimitrov cc69f1a
Merge branch 'master' into mevtimov/feat-8040
kdinev 2ae4eb1
chore(*): added requested changes
ca14b6e
Merge branch 'master' of https://github.com/IgniteUI/igniteui-angular…
59a912f
Merge branch 'mevtimov/feat-8040' of https://github.com/IgniteUI/igni…
6f05d55
chore(*): added requested changes
dedc8d8
chore(*): fix failed tests
d021e78
Merge branch 'master' into mevtimov/feat-8040
kdinev 7320872
Merge branch 'master' into mevtimov/feat-8040
zdrawku b61348e
chore(*): clean up leftover changes
a4de69e
Merge branch 'mevtimov/feat-8040' of https://github.com/IgniteUI/igni…
2ee3aa6
Merge branch 'master' into mevtimov/feat-8040
zdrawku d956838
Merge branch 'master' into mevtimov/feat-8040
zdrawku File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -403,7 +403,7 @@ export class IgxRowDirective<T extends IgxGridBaseDirective & GridType> implemen | |
if (this.grid.rowSelection === 'none' || this.deleted || !this.grid.selectRowOnClick) { | ||
return; | ||
} | ||
if (event.shiftKey && this.grid.rowSelection === 'multiple') { | ||
if (event.shiftKey && this.grid.isMultiRowSelectionEnabled) { | ||
this.selectionService.selectMultipleRows(this.rowID, this.rowData, event); | ||
return; | ||
} | ||
|
@@ -436,7 +436,7 @@ export class IgxRowDirective<T extends IgxGridBaseDirective & GridType> implemen | |
*/ | ||
public onRowSelectorClick(event) { | ||
event.stopPropagation(); | ||
if (event.shiftKey && this.grid.rowSelection === 'multiple') { | ||
if (event.shiftKey && this.grid.isMultiRowSelectionEnabled) { | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Good! |
||
this.selectionService.selectMultipleRows(this.rowID, this.rowData, event); | ||
return; | ||
} | ||
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good!