Skip to content

refactor(themes): add scoped vars #8865

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 14 commits into from
Feb 11, 2021
Merged

refactor(themes): add scoped vars #8865

merged 14 commits into from
Feb 11, 2021

Conversation

simeonoff
Copy link
Collaborator

@simeonoff simeonoff commented Jan 28, 2021 •
edited
Loading

Closes #8868

Additional information (check all that apply):

  • Bug fix
  • New functionality
  • Documentation
  • Demos
  • CI/CD

Checklist:

  • All relevant tags have been applied to this PR
  • This PR includes unit tests covering all the new code (test guidelines)
  • This PR includes API docs for newly added methods/properties (api docs guidelines)
  • This PR includes feature/README.MD updates for the feature docs
  • This PR includes general feature table updates in the root README.MD
  • This PR includes CHANGELOG.MD updates for newly added functionality
  • This PR contains breaking changes
  • This PR includes ng update migrations for the breaking changes (migrations guidelines)
  • This PR includes behavioral changes and the feature specification has been updated with them

@simeonoff simeonoff changed the title Simeonoff/scoped vars refactor(themes): add scoped vars Jan 28, 2021
@simeonoff simeonoff requested a review from desig9stein January 28, 2021 14:11
@simeonoff simeonoff marked this pull request as draft January 28, 2021 14:12
@simeonoff simeonoff force-pushed the simeonoff/scoped-vars branch from 4d831a3 to 9dd4f13 Compare January 30, 2021 13:52
@simeonoff simeonoff linked an issue Feb 8, 2021 that may be closed by this pull request
Themes: Scope custom CSS props to component selectors #8868
Closed
@simeonoff simeonoff marked this pull request as ready for review February 9, 2021 16:14
@simeonoff simeonoff requested a review from SisIvanova February 9, 2021 16:14
@simeonoff simeonoff merged commit c5aee9e into simeonoff/css-var-refs Feb 11, 2021
@simeonoff simeonoff deleted the simeonoff/scoped-vars branch February 11, 2021 09:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@desig9stein desig9stein desig9stein approved these changes

@SisIvanova SisIvanova Awaiting requested review from SisIvanova

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Themes: Scope custom CSS props to component selectors
2 participants
@simeonoff @desig9stein