Skip to content

IgxDatePicker refactoring #8939

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 6 commits into from
Apr 7, 2021
Merged

IgxDatePicker refactoring #8939

merged 6 commits into from
Apr 7, 2021

Conversation

jackofdiamond5
Copy link
Member

@jackofdiamond5 jackofdiamond5 commented Feb 9, 2021 •
edited by Lipata
Loading

Closes #6483
Closes #7199
Closes #7169

Additional information (check all that apply):

  • Bug fix
  • New functionality
  • Documentation
  • Demos
  • CI/CD

Checklist:

  • All relevant tags have been applied to this PR
  • This PR includes unit tests covering all the new code (test guidelines)
  • This PR includes API docs for newly added methods/properties (api docs guidelines)
  • This PR includes feature/README.MD updates for the feature docs
  • This PR includes general feature table updates in the root README.MD
  • This PR includes CHANGELOG.MD updates for newly added functionality
  • This PR contains breaking changes
  • This PR includes ng update migrations for the breaking changes (migrations guidelines)
  • This PR includes behavioral changes and the feature specification has been updated with them

@jackofdiamond5 jackofdiamond5 mentioned this pull request Mar 12, 2021
Merged
14 tasks
@jackofdiamond5 jackofdiamond5 added refactoring ❌ status: awaiting-test PRs awaiting manual verification labels Mar 12, 2021
@jackofdiamond5 jackofdiamond5 marked this pull request as ready for review March 12, 2021 12:42
@jackofdiamond5 jackofdiamond5 force-pushed the bpenkov/date-picker-refactoring branch 2 times, most recently from b4edbad to 625606b Compare April 1, 2021 15:50
damyanpetev
damyanpetev reviewed Apr 2, 2021
View reviewed changes
damyanpetev
damyanpetev reviewed Apr 2, 2021
View reviewed changes
projects/igniteui-angular/src/lib/date-picker/date-picker.common.ts Outdated
* when onValidationFailed event is fired.
*/
export interface IDatePickerValidationFailedEventArgs extends IBaseEventArgs {
owner: IgxDatePickerComponent;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hmm this seems like a good candidate to make base args generic, so we don't need to override the prop to type it correctly.

@damyanpetev damyanpetev removed the ❌ status: awaiting-test PRs awaiting manual verification label Apr 6, 2021
@jackofdiamond5 jackofdiamond5 force-pushed the bpenkov/date-picker-refactoring branch from 10f73f0 to 905edfc Compare April 6, 2021 12:12
@jackofdiamond5 jackofdiamond5 force-pushed the bpenkov/date-picker-refactoring branch from 2ad9b6a to 7f767f7 Compare April 7, 2021 10:14
@Lipata Lipata merged commit 5d947c2 into pickers-refactoring Apr 7, 2021
@Lipata Lipata deleted the bpenkov/date-picker-refactoring branch April 7, 2021 10:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Lipata Lipata Lipata left review comments

@damyanpetev damyanpetev damyanpetev left review comments

Assignees
No one assigned
Labels
📅 date-picker refactoring
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jackofdiamond5 @Lipata @damyanpetev