Skip to content

feat(igx-hierarchical-grid): export hierarchical grid #9206

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 25 commits into from
Apr 19, 2021
Merged

feat(igx-hierarchical-grid): export hierarchical grid #9206

merged 25 commits into from
Apr 19, 2021

Conversation

onlyexeption
Copy link
Contributor

@onlyexeption onlyexeption commented Mar 25, 2021 •
edited
Loading

Closes #5848

Additional information (check all that apply):

  • Bug fix
  • New functionality
  • Documentation
  • Demos
  • CI/CD

Checklist:

  • All relevant tags have been applied to this PR
  • This PR includes unit tests covering all the new code (test guidelines)
  • This PR includes API docs for newly added methods/properties (api docs guidelines)
  • This PR includes feature/README.MD updates for the feature docs
  • This PR includes general feature table updates in the root README.MD
  • This PR includes CHANGELOG.MD updates for newly added functionality
  • This PR contains breaking changes
  • This PR includes ng update migrations for the breaking changes (migrations guidelines)
  • This PR includes behavioral changes and the feature specification has been updated with them

@onlyexeption onlyexeption requested a review from gedinakova April 5, 2021 11:33
gedinakova
gedinakova requested changes Apr 7, 2021
View reviewed changes
projects/igniteui-angular/src/lib/services/excel/excel-files.ts
this.rowHeight = height ? ' ht="' + height + '" customHeight="1"' : '';
sheetData += `<row r="1"${this.rowHeight}>`;
const rowStyle = isHierarchicalGrid ? ' s="3"' : '';
this.rowHeight = height ? ` ht="${height}" customHeight="1"` : '';
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We could probably extract the setting rowHeight logic in a method (I saw this used elsewhere).

DiyanDimitrov
DiyanDimitrov suggested changes Apr 7, 2021
View reviewed changes
gedinakova
gedinakova requested changes Apr 13, 2021
View reviewed changes
Copy link
Contributor

@gedinakova gedinakova left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@onlyexeption We need to account for the limitations of total rows and columns on a worksheet as defined by Excel specifications.
Currently, if you attempt to export the first hierarchical grid in the first dev demo, the export will fail because the rows count is over 3 million while the limitation is a little over 1 million.

@gedinakova gedinakova self-requested a review April 15, 2021 15:44
@onlyexeption onlyexeption marked this pull request as ready for review April 16, 2021 10:07
@gedinakova gedinakova added 💥 status: in-test PRs currently being tested and removed ❌ status: awaiting-test PRs awaiting manual verification labels Apr 16, 2021
@DiyanDimitrov DiyanDimitrov self-requested a review April 19, 2021 08:38
@DiyanDimitrov
Copy link
Contributor

Add the new feature to the changelog.

@gedinakova gedinakova self-assigned this Apr 19, 2021
@gedinakova gedinakova added ✅ status: verified Applies to PRs that have passed manual verification and removed 💥 status: in-test PRs currently being tested labels Apr 19, 2021
@gedinakova gedinakova merged commit dbdb58b into master Apr 19, 2021
@gedinakova gedinakova deleted the ibarakov/feat-5848-master branch April 19, 2021 10:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gedinakova gedinakova gedinakova approved these changes

@DiyanDimitrov DiyanDimitrov DiyanDimitrov approved these changes

Assignees

@gedinakova gedinakova

Labels
excel-exporter grid: hierarchical-grid version: 12.0.x ✅ status: verified Applies to PRs that have passed manual verification
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Export Hierarchical Grid to Excel
3 participants
@onlyexeption @DiyanDimitrov @gedinakova