Grids templates refactoring #9256
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Moved common template logic for the grid header area in a header row component. * Group by logic is encapsulated in its own component now.
* Use new components in templates * Code styling, types and cleanups
* More code styles, types and cleanup
* Cleanup code and add types where applicable
…into rkaraivanov/grids-spa-and-wellbeing
* Adjusted unit tests * Expose native element on chip component and adjust tests
…into rkaraivanov/grids-spa-and-wellbeing
…into rkaraivanov/grids-spa-and-wellbeing
…into rkaraivanov/grids-spa-and-wellbeing
…into rkaraivanov/grids-spa-and-wellbeing
…into rkaraivanov/grids-spa-and-wellbeing
…into rkaraivanov/grids-spa-and-wellbeing
…into rkaraivanov/grids-spa-and-wellbeing
…into rkaraivanov/grids-spa-and-wellbeing
…into rkaraivanov/grids-spa-and-wellbeing
…into rkaraivanov/grids-spa-and-wellbeing
…into rkaraivanov/grids-spa-and-wellbeing
…into rkaraivanov/grids-spa-and-wellbeing
…into rkaraivanov/grids-spa-and-wellbeing
…into rkaraivanov/grids-spa-and-wellbeing
…into rkaraivanov/grids-spa-and-wellbeing
…into rkaraivanov/grids-spa-and-wellbeing
…into rkaraivanov/grids-spa-and-wellbeing
…into rkaraivanov/grids-spa-and-wellbeing
…into rkaraivanov/grids-spa-and-wellbeing
…com/IgniteUI/igniteui-angular into rkaraivanov/grids-spa-and-wellbeing
Column moving unit test refactor
kdinev
previously approved these changes
Jun 28, 2021
simeonoff
previously approved these changes
Jun 28, 2021
ddincheva
added
💥 status: in-test
ddincheva
added
✅ status: verified
| * @hidden @internal | ||
| */ | ||
| @Component({ | ||
| changeDetection: ChangeDetectionStrategy.OnPush, |
There was a problem hiding this comment.
Reordering chips in the group by area doesn't work very well with OnPush strategy. That's why we have removed it in the Tree Grid Group By Area PR.
…into rkaraivanov/grids-spa-and-wellbeing
* Group area consolidation and fixes * Some typings for grid outlets * Prevented circular dep for the row directive from the services barrel file
kdinev
approved these changes
Jul 6, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #9556
feat: Refactored grid header row templates/logic into a separate component to be used by the grids
feat: Group-by area is encapsulated as its own component
refactor: Various API changes (internal only). Simplified some templates, abstracted some logic
refactor: Drag scroll behaviors (column moving, range cell selection) are now aligned with the new grid scroll animation frame
behavior. Got to be smooth..
refactor: Unit test adjustments
Additional information (check all that apply):
Checklist:
feature/README.MDupdates for the feature docsREADME.MDCHANGELOG.MDupdates for newly added functionalityng updatemigrations for the breaking changes (migrations guidelines)