Skip to content

refactor(snackbar): should implement IToggleView #9733

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 14 commits into from
Jun 29, 2021
Merged

refactor(snackbar): should implement IToggleView #9733

merged 14 commits into from
Jun 29, 2021

Conversation

SisIvanova
Copy link
Collaborator

@SisIvanova SisIvanova commented Jun 16, 2021 •
edited by simeonoff
Loading

Closes #9678, #9677

Additional information (check all that apply):

  • Bug fix
  • New functionality
  • Documentation
  • Demos
  • CI/CD

Checklist:

  • All relevant tags have been applied to this PR
  • This PR includes unit tests covering all the new code (test guidelines)
  • This PR includes API docs for newly added methods/properties (api docs guidelines)
  • This PR includes feature/README.MD updates for the feature docs
  • This PR includes general feature table updates in the root README.MD
  • This PR includes CHANGELOG.MD updates for newly added functionality
  • This PR contains breaking changes
  • This PR includes ng update migrations for the breaking changes (migrations guidelines)
  • This PR includes behavioral changes and the feature specification has been updated with them

@SisIvanova SisIvanova requested a review from simeonoff June 16, 2021 11:49
@SisIvanova SisIvanova linked an issue Jun 16, 2021 that may be closed by this pull request
Snackbar should implement IToggleView #9677
Closed
simeonoff
simeonoff reviewed Jun 16, 2021
View reviewed changes
Copy link
Collaborator

@simeonoff simeonoff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See comments.

@SisIvanova SisIvanova marked this pull request as ready for review June 23, 2021 10:06
@SisIvanova SisIvanova added the ❌ status: awaiting-test PRs awaiting manual verification label Jun 24, 2021
simeonoff
simeonoff reviewed Jun 25, 2021
View reviewed changes
Copy link
Collaborator

@simeonoff simeonoff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add a changelog entry to reflect the removal of the deprecated message property. Review and update all typedoc comments to reflect the implemented changes.

@simeonoff simeonoff added 💥 status: in-test PRs currently being tested and removed ❌ status: awaiting-test PRs awaiting manual verification labels Jun 29, 2021
@simeonoff simeonoff added toast ✅ status: verified Applies to PRs that have passed manual verification and removed 💥 status: in-test PRs currently being tested labels Jun 29, 2021
@simeonoff simeonoff self-requested a review June 29, 2021 08:21
@simeonoff simeonoff merged commit e86a130 into master Jun 29, 2021
@simeonoff simeonoff deleted the SIvanova/snackbar-refactoring branch June 29, 2021 08:22
@SisIvanova SisIvanova mentioned this pull request Jun 30, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@simeonoff simeonoff simeonoff approved these changes

Assignees
No one assigned
Labels
snackbar toast toggle version: 12.1.x ✅ status: verified Applies to PRs that have passed manual verification
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Snackbar is not positioned as per documentation Snackbar should implement IToggleView
2 participants
@SisIvanova @simeonoff