Skip to content

feat(toolbar): allow passing overlaySettings through every action #9767

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 15 commits into from
Jun 23, 2021
Merged

feat(toolbar): allow passing overlaySettings through every action #9767

merged 15 commits into from
Jun 23, 2021

Conversation

Aleksandyr
Copy link
Contributor

@Aleksandyr Aleksandyr commented Jun 21, 2021 •
edited
Loading

Closes #9065

Additional information (check all that apply):

  • Bug fix
  • New functionality
  • Documentation
  • Demos
  • CI/CD

Checklist:

  • All relevant tags have been applied to this PR
  • This PR includes unit tests covering all the new code (test guidelines)
  • This PR includes API docs for newly added methods/properties (api docs guidelines)
  • This PR includes feature/README.MD updates for the feature docs
  • This PR includes general feature table updates in the root README.MD
  • This PR includes CHANGELOG.MD updates for newly added functionality
  • This PR contains breaking changes
  • This PR includes ng update migrations for the breaking changes (migrations guidelines)
  • This PR includes behavioral changes and the feature specification has been updated with them

@Aleksandyr Aleksandyr added ❌ status: awaiting-test PRs awaiting manual verification grid: toolbar labels Jun 21, 2021
@Aleksandyr Aleksandyr requested a review from zdrawku June 21, 2021 12:47
@zdrawku zdrawku changed the title feat(toolbar): allow passing position strategy through every action feat(toolbar): allow passing overlaySettings through every action Jun 23, 2021
@zdrawku zdrawku added 💥 status: in-test PRs currently being tested and removed ❌ status: awaiting-test PRs awaiting manual verification labels Jun 23, 2021
@zdrawku zdrawku added ✅ status: verified Applies to PRs that have passed manual verification and removed 💥 status: in-test PRs currently being tested labels Jun 23, 2021
@zdrawku zdrawku merged commit ef0f4af into master Jun 23, 2021
@zdrawku zdrawku deleted the pos-strategy-toolbar branch June 23, 2021 14:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zdrawku zdrawku zdrawku approved these changes

@rkaraivanov rkaraivanov rkaraivanov approved these changes

Assignees

@zdrawku zdrawku

Labels
grid: toolbar version: 12.1.x ✅ status: verified Applies to PRs that have passed manual verification
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Allow for passing a positioning strategy to IgxGridToolbarHidingComponent
3 participants
@Aleksandyr @zdrawku @rkaraivanov