Skip to content

fix(time-picker): fix time picker pan event #9717 #9973

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 11 commits into from
Aug 20, 2021
Merged

fix(time-picker): fix time picker pan event #9717 #9973

merged 11 commits into from
Aug 20, 2021

Conversation

PlamenaMiteva
Copy link
Contributor

Closes #9717

Additional information (check all that apply):

  • Bug fix
  • New functionality
  • Documentation
  • Demos
  • CI/CD

Checklist:

  • All relevant tags have been applied to this PR
  • This PR includes unit tests covering all the new code (test guidelines)
  • This PR includes API docs for newly added methods/properties (api docs guidelines)
  • This PR includes feature/README.MD updates for the feature docs
  • This PR includes general feature table updates in the root README.MD
  • This PR includes CHANGELOG.MD updates for newly added functionality
  • This PR contains breaking changes
  • This PR includes ng update migrations for the breaking changes (migrations guidelines)
  • This PR includes behavioral changes and the feature specification has been updated with them

@Lipata Lipata added the ❌ status: awaiting-test PRs awaiting manual verification label Aug 12, 2021
@Lipata Lipata requested a review from ViktorSlavov August 12, 2021 12:47
ViktorSlavov
ViktorSlavov suggested changes Aug 12, 2021
View reviewed changes
Copy link
Contributor

@ViktorSlavov ViktorSlavov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is it possible to add a test for the scenario?

@Lipata Lipata requested a review from ViktorSlavov August 13, 2021 13:26
ViktorSlavov
ViktorSlavov previously approved these changes Aug 17, 2021
View reviewed changes
@Lipata Lipata added 💥 status: in-test PRs currently being tested and removed ❌ status: awaiting-test PRs awaiting manual verification labels Aug 18, 2021
@Lipata Lipata added ✅ status: verified Applies to PRs that have passed manual verification squash-merge Merge PR with "Squash and Merge" option and removed 💥 status: in-test PRs currently being tested labels Aug 20, 2021
@Lipata
Copy link
Member

Lipata commented Aug 20, 2021

Having threshold 10 for hammer.js config seems fine for both Android and iOS devices. However, because there isn't a scroll animation and inertia the experience seems that can be improved a lot. There is a separate issue for that: #6292.

@Lipata Lipata merged commit 1e20140 into 12.1.x Aug 20, 2021
@Lipata Lipata deleted the PMiteva/fix-9717-12.1.x branch August 20, 2021 06:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jackofdiamond5 jackofdiamond5 jackofdiamond5 approved these changes

@ViktorSlavov ViktorSlavov ViktorSlavov approved these changes

Assignees

@valadzhov valadzhov

Labels
🕐 time-picker squash-merge Merge PR with "Squash and Merge" option version: 12.1.x ✅ status: verified Applies to PRs that have passed manual verification
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@PlamenaMiteva @Lipata @jackofdiamond5 @ViktorSlavov @valadzhov