Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add lottie animation when we upload files #423

Draft
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

tevincent
Copy link
Contributor

@tevincent tevincent commented Feb 21, 2025

Swiss flag:

flag_light.mp4
flag.mp4

Gondola:

montain_gondola_light.mp4
mountain_gondola_dark.mp4

Safe:

safe_light.mp4
safe.mp4

@LunarX
Copy link
Contributor

LunarX commented Feb 21, 2025

The dark mountain and gondola has lost its shadow on the mountain compared the static version and light version

@KevinBoulongne KevinBoulongne marked this pull request as draft February 24, 2025 12:42
@tevincent tevincent marked this pull request as ready for review February 25, 2025 09:37
@tevincent tevincent force-pushed the update-lottie branch 2 times, most recently from ef04654 to 1ea7cb7 Compare February 26, 2025 08:30
@tevincent
Copy link
Contributor Author

The dark mountain and gondola has lost its shadow on the mountain compared the static version and light version

I've updated the faulty lottie. It's good now.

@LunarX LunarX self-requested a review February 26, 2025 09:56
Copy link
Contributor

@LunarX LunarX left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The light gondola animation has the gondola stop for a brief instant at the top and bottom of the cable but the dark gondola animation never stops

Copy link
Contributor

@LunarX LunarX left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not only do the light and dark flag not have the same flag size but also, in light mode the flag is not square and in dark mode the flag has strange red lines on the white cross:

Screenshot_1740572817
Screenshot_1740572821

Copy link
Contributor

@LunarX LunarX left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

At the end of the safe animation, when it loops back to the start, the three little star shaped symbols jump to a new rotation angle which is staring

@KevinBoulongne KevinBoulongne marked this pull request as draft February 27, 2025 10:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants