feat: Matomo basic #450
Draft
feat: Matomo basic #450
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
FabianDevel
force-pushed
the
matomo-basic
branch
from
8d2ec9f to
679c103
Compare
LunarX
requested changes
Mar 5, 2025
|
|
||
| @Serializable | ||
| data object ImportFilesDestination : NewTransferNavigation() | ||
| data object ImportFilesDestination : NewTransferNavigation("ImportFileView") |
There was a problem hiding this comment.
This destination should soon change after @LouisCAD 's PR. Would we want to already use a name that matches the new screen name so we don't send incoherent values to matomo?
There was a problem hiding this comment.
Now that we have the need to name each destination, we should align with iOS, that's why we should use this name, and not the current nor future class's name
There was a problem hiding this comment.
After talking about it in real, the problem is not the fact that he destination will change, it's that some destination will totally be erased
app/src/main/java/com/infomaniak/swisstransfer/ui/navigation/NavigationDestination.kt
Show resolved
Hide resolved
app/src/main/java/com/infomaniak/swisstransfer/ui/navigation/NavigationDestination.kt
Show resolved
Hide resolved
...infomaniak/swisstransfer/ui/screen/newtransfer/importfiles/components/TransferTypeButtons.kt
Outdated
Show resolved
Hide resolved
app/src/main/java/com/infomaniak/swisstransfer/ui/screen/main/MainScreen.kt
Outdated
Show resolved
Hide resolved
KevinBoulongne
requested changes
Mar 6, 2025
...rc/main/java/com/infomaniak/swisstransfer/ui/screen/main/transfers/TransfersScreenWrapper.kt
Outdated
Show resolved
Hide resolved
tevincent
approved these changes
Mar 6, 2025
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Waiting for Multiplatform 1.0.10 release