Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Update version of PDFview #1549

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
+5 −4
Open

chore: Update version of PDFview #1549

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
3019fef
chore: Update version of PDFview
tevincent Mar 4, 2025
c90d763
chore: Put a smaller margin at the end of a PDF
tevincent Mar 6, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion app/build.gradle
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -153,7 +153,7 @@ dependencies {
implementation "com.google.android.exoplayer:extension-okhttp:$exoplayer_version"

implementation 'com.airbnb.android:lottie:6.6.2'
implementation 'com.github.Infomaniak:android-pdfview:3.2.10'
implementation 'com.github.Infomaniak:android-pdfview:3.2.11'
implementation 'com.github.MikeOrtiz:TouchImageView:3.5'
implementation 'com.github.rubensousa:gravitysnaphelper:2.2.2'
implementation 'com.tbuonomo:dotsindicator:5.1.0'
Expand Down
7 changes: 4 additions & 3 deletions app/src/main/java/com/infomaniak/drive/ui/fileList/preview/PreviewPDFFragment.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -169,8 +169,8 @@ class PreviewPDFFragment : PreviewFragment(), PDFPrintListener {
pageFling(false)
pageSnap(false)
scrollHandle(scrollHandle)
spacing(PDF_VIEW_HANDLE_TEXT_INDICATOR_SIZE_DP)
startEndSpacing(START_END_SPACING_DP, START_END_SPACING_DP)
pageSeparatorSpacing(PDF_VIEW_HANDLE_TEXT_INDICATOR_SIZE_DP)
startEndSpacing(START_SPACING_DP, END_SPACING_DP)
zoom(MIN_ZOOM, MID_ZOOM, MAX_ZOOM)
swipeHorizontal(false)
touchPriority(true)
Expand Down Expand Up @@ -341,7 +341,8 @@ class PreviewPDFFragment : PreviewFragment(), PDFPrintListener {

companion object {
private const val PDF_VIEW_HANDLE_TEXT_INDICATOR_SIZE_DP = 16
private const val START_END_SPACING_DP = 200
private const val START_SPACING_DP = 150
private const val END_SPACING_DP = 75
private const val MIN_ZOOM = 0.93f
private const val MID_ZOOM = 3f
private const val MAX_ZOOM = 6f
Expand Down