Clean code before SuperCollapsedBlock feature #1683
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
KevinBoulongne
added
the
optimization
KevinBoulongne
force-pushed
the
tablet-focus
branch
from
662bdab to
1a1e5be
Compare
KevinBoulongne
force-pushed
the
clean-code
branch
from
dd2ebcd to
8b95881
Compare
KevinBoulongne
force-pushed
the
tablet-focus
branch
from
1a1e5be to
5f44b97
Compare
KevinBoulongne
force-pushed
the
clean-code
branch
2 times, most recently
from
6b2cb20 to
16b0812
Compare
KevinBoulongne
force-pushed
the
tablet-focus
branch
from
5f44b97 to
a5f0375
Compare
KevinBoulongne
force-pushed
the
clean-code
branch
from
16b0812 to
914e22b
Compare
KevinBoulongne
force-pushed
the
tablet-focus
branch
from
a5f0375 to
954e4d7
Compare
KevinBoulongne
force-pushed
the
clean-code
branch
from
914e22b to
6496a21
Compare
KevinBoulongne
force-pushed
the
tablet-focus
branch
2 times, most recently
from
4b9bd04 to
4608662
Compare
KevinBoulongne
force-pushed
the
clean-code
branch
from
6496a21 to
b51593a
Compare
KevinBoulongne
force-pushed
the
tablet-focus
branch
from
4608662 to
9c90a39
Compare
KevinBoulongne
force-pushed
the
clean-code
branch
from
b51593a to
70b4176
Compare
KevinBoulongne
force-pushed
the
tablet-focus
branch
from
9c90a39 to
8925609
Compare
KevinBoulongne
force-pushed
the
clean-code
branch
3 times, most recently
from
1cf5529 to
0c3d543
Compare
KevinBoulongne
force-pushed
the
tablet-focus
branch
from
8925609 to
07a0d12
Compare
|
This PR/issue depends on:
|
KevinBoulongne
force-pushed
the
clean-code
branch
3 times, most recently
from
ff9abb4 to
6193d76
Compare
Merged
tevincent
requested changes
Feb 6, 2024
| .indexOfFirst { it is Thread && it.uid == threadUid } | ||
| .takeIf { position -> position != -1 } | ||
| } | ||
|
|
There was a problem hiding this comment.
Maybe we can group override methods together?
There was a problem hiding this comment.
We sort them by logic.
| var initialSetOfExpandedMessagesUids = setOf<String>() | ||
| private val currentSetOfLoadedExpandedMessagesUids = mutableSetOf<String>() | ||
| private var hasNotScrolledYet = true | ||
| //endregion |
There was a problem hiding this comment.
Maybe we can also group public and private variables?
There was a problem hiding this comment.
We sort them by logic.
KevinBoulongne
force-pushed
the
clean-code
branch
from
6193d76 to
21fbebd
Compare
|
FabianDevel
approved these changes
Feb 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Depends on #1677