Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stop detecting outlook blockquotes #1720

Merged
merged 1 commit into from
Feb 28, 2024
Merged

Conversation

LunarX
Copy link
Contributor

@LunarX LunarX commented Feb 27, 2024

The id we used to detect outlook blockquotes is not enough. The div with this id only contains the header of the reply/forward but the content of the body of the previous email is right next to this div, at the same level as the div and was therefore not detected.

Instead of half detecting outlook blockquotes, don't detect anything for now until we truly detect them correctly

The id we used to detect outlook blockquotes is not enough. The div with this id only contains the header of the reply/forward but the content of the body of the previous email is right next to this div, at the same level as the div and was therefore not detected.

Instead of half detecting outlook blockquotes, don't detect anything for now until we truly detect them correctly
@LunarX LunarX added bug Something isn't working quick A pull request consisting of a few lines labels Feb 27, 2024
@LunarX LunarX self-assigned this Feb 27, 2024
@LunarX LunarX requested a review from a team as a code owner February 27, 2024 13:33
Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@LunarX LunarX merged commit a9213fc into master Feb 28, 2024
7 checks passed
@LunarX LunarX deleted the fix-outlook-bloquote-detection branch February 28, 2024 07:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working quick A pull request consisting of a few lines
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants