Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

UI now correctly updates when marking Thread as seen #1735

Merged
merged 4 commits into from
Mar 7, 2024
Merged

UI now correctly updates when marking Thread as seen #1735

merged 4 commits into from
Mar 7, 2024

Conversation

KevinBoulongne
Copy link
Contributor

Depends on #1733

@KevinBoulongne KevinBoulongne added the bug Something isn't working label Mar 4, 2024
@KevinBoulongne KevinBoulongne requested a review from a team as a code owner March 4, 2024 08:03
@github-actions github-actions bot added the dependent This MR depends on another PR label Mar 4, 2024
@KevinBoulongne KevinBoulongne changed the title Cancel previous formatList(…) when starting a new one, to avoid race condition when marking Thread as seen UI now correctly updates when marking Thread as seen Mar 4, 2024
Base automatically changed from fix-read to master March 4, 2024 08:32
@github-actions github-actions bot removed the dependent This MR depends on another PR label Mar 4, 2024
@github-actions GitHub Actions
Copy link

github-actions bot commented Mar 4, 2024

This PR/issue depends on:

@KevinBoulongne KevinBoulongne added the rebase Add this label to rebase the PR label Mar 4, 2024
@github-actions github-actions bot removed the rebase Add this label to rebase the PR label Mar 4, 2024
@KevinBoulongne KevinBoulongne force-pushed the fix-read-UI branch 6 times, most recently from d21a309 to 97f34e9 Compare March 7, 2024 06:30
@KevinBoulongne KevinBoulongne enabled auto-merge March 7, 2024 08:25
@KevinBoulongne KevinBoulongne added the rebase Add this label to rebase the PR label Mar 7, 2024
@github-actions github-actions bot removed the rebase Add this label to rebase the PR label Mar 7, 2024
@KevinBoulongne KevinBoulongne added the rebase Add this label to rebase the PR label Mar 7, 2024
@github-actions github-actions bot removed the rebase Add this label to rebase the PR label Mar 7, 2024
@tevincent tevincent requested a review from LunarX March 7, 2024 08:43
@sonarqubecloud SonarQubeCloud
Copy link

sonarqubecloud bot commented Mar 7, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@KevinBoulongne KevinBoulongne merged commit 72825ce into master Mar 7, 2024
4 checks passed
@KevinBoulongne KevinBoulongne deleted the fix-read-UI branch March 7, 2024 09:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@LunarX LunarX LunarX approved these changes

@FabianDevel FabianDevel FabianDevel approved these changes

Assignees

@KevinBoulongne KevinBoulongne

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@KevinBoulongne @LunarX @FabianDevel