Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Place information icon of external banner to the left of the banner #1880

Merged
merged 2 commits into from
Jun 10, 2024
Merged

Place information icon of external banner to the left of the banner #1880

merged 2 commits into from
Jun 10, 2024

Conversation

LunarX
Copy link
Contributor

@LunarX LunarX commented May 30, 2024

Avoids missclicking the close icon instead according to designers

@LunarX LunarX added enhancement Improve or expand upon an existing feature quick A pull request consisting of a few lines labels May 30, 2024
@LunarX LunarX requested a review from a team May 30, 2024 07:22
@LunarX LunarX self-assigned this May 30, 2024
@KevinBoulongne KevinBoulongne added the rebase Add this label to rebase the PR label May 31, 2024
@github-actions github-actions bot removed the rebase Add this label to rebase the PR label May 31, 2024
@KevinBoulongne KevinBoulongne added the rebase Add this label to rebase the PR label May 31, 2024
@github-actions github-actions bot removed the rebase Add this label to rebase the PR label May 31, 2024
@KevinBoulongne KevinBoulongne added the rebase Add this label to rebase the PR label May 31, 2024
@github-actions github-actions bot removed the rebase Add this label to rebase the PR label May 31, 2024
@KevinBoulongne KevinBoulongne added the rebase Add this label to rebase the PR label Jun 3, 2024
@github-actions github-actions bot removed the rebase Add this label to rebase the PR label Jun 3, 2024
@LunarX LunarX force-pushed the fix-external-banner branch from fa8abc0 to 427523f Compare June 5, 2024 07:08
@LunarX LunarX force-pushed the fix-external-banner branch from 427523f to 20f29a9 Compare June 10, 2024 07:17
@LunarX LunarX enabled auto-merge June 10, 2024 07:19
@LunarX LunarX force-pushed the fix-external-banner branch from 20f29a9 to 96d659f Compare June 10, 2024 07:20
@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@LunarX LunarX merged commit 2f96571 into master Jun 10, 2024
4 checks passed
@LunarX LunarX deleted the fix-external-banner branch June 10, 2024 07:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@KevinBoulongne KevinBoulongne KevinBoulongne approved these changes

@tevincent tevincent tevincent approved these changes

Assignees

@LunarX LunarX

Labels
enhancement Improve or expand upon an existing feature quick A pull request consisting of a few lines
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@LunarX @KevinBoulongne @tevincent