Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update caret color of the rich html editor #1959

Merged
merged 4 commits into from
Aug 6, 2024
Merged

Conversation

LunarX
Copy link
Contributor

@LunarX LunarX commented Jul 11, 2024

Make the rich html editor's color follow the theme of the app

Depends on #1958

@LunarX LunarX added the enhancement Improve or expand upon an existing feature label Jul 11, 2024
@LunarX LunarX requested a review from a team July 11, 2024 11:21
@LunarX LunarX self-assigned this Jul 11, 2024
@github-actions github-actions bot added the dependent This MR depends on another PR label Jul 11, 2024
@LunarX LunarX force-pushed the update-caret-color branch 2 times, most recently from 1edb468 to d6a8bda Compare July 12, 2024 07:27
@LunarX LunarX requested a review from KevinBoulongne July 16, 2024 07:35
Copy link
Contributor

@FabianDevel FabianDevel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The ci crash because of a compilation error on the fDroid flavor

@LunarX
Copy link
Contributor Author

LunarX commented Jul 22, 2024

The CI crash is caused by the branch "editor" on which this one relies on. The CI will block this PR from getting merged until it's solved anyway

@LunarX LunarX requested a review from FabianDevel July 22, 2024 07:25
@LunarX LunarX force-pushed the update-caret-color branch from 8e1c434 to 2cc2ebd Compare July 24, 2024 07:29
@LunarX LunarX force-pushed the update-caret-color branch 2 times, most recently from bc48c45 to aded34c Compare July 26, 2024 11:57
@LunarX LunarX force-pushed the update-caret-color branch from aded34c to c0645d1 Compare July 30, 2024 06:44
@LunarX LunarX force-pushed the update-caret-color branch 4 times, most recently from d8a3b69 to 5a1aae6 Compare August 2, 2024 07:55
@LunarX LunarX force-pushed the update-caret-color branch 3 times, most recently from 83a6b03 to b9983fa Compare August 6, 2024 12:11
Base automatically changed from editor to master August 6, 2024 12:16
@github-actions github-actions bot removed the dependent This MR depends on another PR label Aug 6, 2024
Copy link

github-actions bot commented Aug 6, 2024

This PR/issue depends on:

@KevinBoulongne KevinBoulongne added the rebase Add this label to rebase the PR label Aug 6, 2024
@github-actions github-actions bot removed the rebase Add this label to rebase the PR label Aug 6, 2024
Copy link

sonarqubecloud bot commented Aug 6, 2024

@KevinBoulongne KevinBoulongne merged commit ae1dd0e into master Aug 6, 2024
4 checks passed
@KevinBoulongne KevinBoulongne deleted the update-caret-color branch August 6, 2024 12:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Improve or expand upon an existing feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants