Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add more breadcrumbs to better understand Attachments issues #1982

Merged
merged 5 commits into from
Jul 29, 2024
Merged

Add more breadcrumbs to better understand Attachments issues #1982

merged 5 commits into from
Jul 29, 2024

Conversation

KevinBoulongne
Copy link
Contributor

No description provided.

@KevinBoulongne KevinBoulongne added the optimization Improve the performance or efficiency of the code label Jul 26, 2024
@KevinBoulongne KevinBoulongne requested a review from a team July 26, 2024 07:45
@KevinBoulongne KevinBoulongne enabled auto-merge July 26, 2024 09:13
@KevinBoulongne KevinBoulongne force-pushed the attachments-sentry-breadcrumbs branch from d245a00 to 2534475 Compare July 26, 2024 09:16
@tevincent
Copy link
Contributor

You also have a code smell.

LunarX
LunarX requested changes Jul 29, 2024
View reviewed changes
Copy link
Contributor

@LunarX LunarX left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add a keyword so each different step where we record a breadcrumb can be identified. This way when analyzing the breadcrumbs we know which step introduces the issue

@KevinBoulongne KevinBoulongne force-pushed the attachments-sentry-breadcrumbs branch from 2534475 to a0d590d Compare July 29, 2024 07:02
@KevinBoulongne KevinBoulongne force-pushed the attachments-sentry-breadcrumbs branch from d9944bd to 0d4e6bd Compare July 29, 2024 08:03
@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@KevinBoulongne KevinBoulongne disabled auto-merge July 29, 2024 11:04
@KevinBoulongne KevinBoulongne merged commit fb97e4d into master Jul 29, 2024
4 checks passed
@KevinBoulongne KevinBoulongne deleted the attachments-sentry-breadcrumbs branch July 29, 2024 11:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@LunarX LunarX LunarX requested changes

@tevincent tevincent tevincent requested changes

Assignees

@KevinBoulongne KevinBoulongne

Labels
optimization Improve the performance or efficiency of the code
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@KevinBoulongne @tevincent @LunarX