Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove associated inline attachements when removing quote #1992

Merged
merged 2 commits into from
Aug 7, 2024

Conversation

LunarX
Copy link
Contributor

@LunarX LunarX commented Aug 2, 2024

If we want to remove cids contained in the quote, we can simply remove it like this.

This way, when forwarding an email with inline attachments, if we remove the forwarding block, we also discard its associated inline attachments

@LunarX LunarX added bug Something isn't working enhancement Improve or expand upon an existing feature labels Aug 2, 2024
@LunarX LunarX requested a review from a team August 2, 2024 09:45
@LunarX LunarX self-assigned this Aug 2, 2024
@LunarX LunarX marked this pull request as draft August 2, 2024 09:48
@LunarX LunarX marked this pull request as ready for review August 6, 2024 07:55
@LunarX LunarX force-pushed the remove-unused-cids branch 2 times, most recently from a5d4669 to 272386c Compare August 6, 2024 12:43
@LunarX LunarX requested a review from KevinBoulongne August 7, 2024 08:33
@LunarX LunarX force-pushed the remove-unused-cids branch from 7204073 to caa05b0 Compare August 7, 2024 08:39
@LunarX LunarX enabled auto-merge August 7, 2024 08:39
Copy link

sonarqubecloud bot commented Aug 7, 2024

@LunarX LunarX merged commit d9c1761 into master Aug 7, 2024
4 checks passed
@LunarX LunarX deleted the remove-unused-cids branch August 7, 2024 08:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working enhancement Improve or expand upon an existing feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants