Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow keyboard navigation #1993

Merged
merged 23 commits into from
Aug 15, 2024
Merged

Allow keyboard navigation #1993

merged 23 commits into from
Aug 15, 2024

Conversation

NicolasBourdin88
Copy link
Contributor

Allow to navigate everywhere with keyboard except :

  • Thread when there is no focusable button
  • Going back to bottom sheet dialog (the problem is that the user can't go back without making an action)

@NicolasBourdin88 NicolasBourdin88 requested review from LunarX and a team August 5, 2024 11:23
@NicolasBourdin88 NicolasBourdin88 self-assigned this Aug 5, 2024
@NicolasBourdin88 NicolasBourdin88 marked this pull request as ready for review August 6, 2024 08:30
LunarX
LunarX reviewed Aug 7, 2024
View reviewed changes
Copy link
Contributor

@LunarX LunarX left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

When backing from the profile, the focus seems to be lost somewhere on the bottom item of the thread list. Is this, configurable or not?

LunarX
LunarX reviewed Aug 7, 2024
View reviewed changes
Copy link
Contributor

@LunarX LunarX left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we also want to change the keyboard navigation inside the new message activity?

@LunarX
Copy link
Contributor

LunarX commented Aug 7, 2024

Same question for settings

@NicolasBourdin88 NicolasBourdin88 added the feature Add a new function or capability to the project label Aug 7, 2024
@NicolasBourdin88 NicolasBourdin88 force-pushed the better-focus branch 6 times, most recently from 0a450bf to 9c4e3b0 Compare August 14, 2024 11:17
@NicolasBourdin88 NicolasBourdin88 force-pushed the better-focus branch 2 times, most recently from 4270e00 to 20eb71b Compare August 14, 2024 13:38
@NicolasBourdin88 @KevinBoulongne
Improve tab navigation while navigating in thread list
67e403c
@NicolasBourdin88 @KevinBoulongne
Add right arrow navigation to go to new message button
288408e
@NicolasBourdin88 @KevinBoulongne
Make Toolbar focusable when using keyboard navigation
582be0c
@NicolasBourdin88 @KevinBoulongne
Set avatar focusable
d00ac5f
@NicolasBourdin88 @KevinBoulongne
Allow to select folder on search fragment
b4edb8c
@NicolasBourdin88 @KevinBoulongne
Navigate in toolbar in Thread Fragment
24e886b
@NicolasBourdin88 @KevinBoulongne
Unable to select avatar on ThreadListFragment
78f4600
@NicolasBourdin88 @KevinBoulongne
Override setFocusable so it affect the avatar root view
3850e85
@NicolasBourdin88 @KevinBoulongne
Remove focus set on all page when switching fragment
1504c62
@NicolasBourdin88 @KevinBoulongne
Reformat
9adb04d
@NicolasBourdin88 @KevinBoulongne
Apply suggestion from code review
07bfe07
@NicolasBourdin88 @KevinBoulongne
Remove useless isFocusable
9052397
@NicolasBourdin88 @KevinBoulongne
Avoid drawer from getting focus
8c10ecd
@NicolasBourdin88 @KevinBoulongne
Remember focus after navigating from Fragment to Fragment
cbdbe75 
Don't work on ThreadListFragment because we don't stop the fragment after selecting another thread
@NicolasBourdin88 @KevinBoulongne
Remember focus in MailboxSettingsFragment
bc87e57
@NicolasBourdin88 @KevinBoulongne
Apply suggestion from code review
2b10142
@NicolasBourdin88 @KevinBoulongne
Avoid signature Webview to get focus and get clicked
ff30e9a
@NicolasBourdin88 @KevinBoulongne
Reformat comment to avoid it to be > 131 characters
ed8533c
@NicolasBourdin88 @KevinBoulongne
Avoid scrolling when clicking on web view
43ffd95
@NicolasBourdin88 @KevinBoulongne
Add commentary
0a9ad2e
@NicolasBourdin88 @KevinBoulongne
Refractor
50ce437
@github-actions github-actions bot removed the rebase Add this label to rebase the PR label Aug 15, 2024
@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@NicolasBourdin88 NicolasBourdin88 merged commit 111c7d7 into master Aug 15, 2024
4 checks passed
@NicolasBourdin88 NicolasBourdin88 deleted the better-focus branch August 15, 2024 13:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@KevinBoulongne KevinBoulongne KevinBoulongne approved these changes

@LunarX LunarX LunarX approved these changes

Assignees

@NicolasBourdin88 NicolasBourdin88

Labels
feature Add a new function or capability to the project
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@NicolasBourdin88 @LunarX @KevinBoulongne