Add toolbar formatting options to the new rich html editor by LunarX · Pull Request #1996 · Infomaniak/android-kMail

Redo the tooolbar layout

LunarX

committed

Connect format option buttons to their respective action

LunarX

committed

Disable toolbar formatting options when the webview is unfocused

LunarX

committed

Coherent naming across editor format action methods

LunarX

committed

Correctly build the toolbar content so it's easy to swap between the two possible set of buttons

LunarX

committed

Add content descriptions to the formatting options buttons

LunarX

committed

Remove send button and divider from the formatting options toolbar

LunarX

committed

Add insert link dialog

LunarX

committed

Use common dialog title

LunarX

committed

Move link inside edition toolbar so it can be displayed as activated and disabled

LunarX

committed

Remove prefilled default values until we actually handle them properly

LunarX

committed

Focus the editor if the format toolbar is opened

LunarX

committed

Add url validation

LunarX

committed

Fix url error end icon padding

LunarX

committed

Correctly reset the insert dialog edit text states when opening the dialog again

LunarX

committed

Fix insert dialog paddings

LunarX

committed

Automatically focus url field when opening insert link dialog

LunarX

committed

Simplify the synchronizing of display text and url to avoid unnecessary bugs and improve the UX

LunarX

committed

Clean some code before opening the PR for reviews

LunarX

committed

Add missing RCore import

KevinBoulongne

authored and

LunarX

committed

Only set `urlEditText.doOnTextChanged { … }` listener once

KevinBoulongne

authored and

LunarX

committed

Extract PROTOCOL_SEPARATOR to companion object

KevinBoulongne

authored and

LunarX

committed

Oneline validate method for link insertion

KevinBoulongne

authored and

LunarX

committed

Fix wrongly renamed view

LunarX

committed

Remove unnecessary var

LunarX

committed

Remove useless new line

LunarX

committed

Refactor updateEditorVisibility with better method and argument name

LunarX

committed

Add missing coma

LunarX

committed

Fix comment

LunarX

committed

Simplify editor focus handling

LunarX

committed

Apply suggestions from code review

LunarX

committed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add toolbar formatting options to the new rich html editor#1996

Commits on Aug 14, 2024

Redo the tooolbar layout

Connect format option buttons to their respective action

Disable toolbar formatting options when the webview is unfocused

Coherent naming across editor format action methods

Correctly build the toolbar content so it's easy to swap between the two possible set of buttons

Add content descriptions to the formatting options buttons

Remove send button and divider from the formatting options toolbar

Add insert link dialog

Use common dialog title

Move link inside edition toolbar so it can be displayed as activated and disabled

Remove prefilled default values until we actually handle them properly

Focus the editor if the format toolbar is opened

Add url validation

Fix url error end icon padding

Correctly reset the insert dialog edit text states when opening the dialog again

Fix insert dialog paddings

Automatically focus url field when opening insert link dialog

Simplify the synchronizing of display text and url to avoid unnecessary bugs and improve the UX

Clean some code before opening the PR for reviews

Add missing RCore import

Only set `urlEditText.doOnTextChanged { … }` listener once

Extract PROTOCOL_SEPARATOR to companion object

Oneline validate method for link insertion

Fix wrongly renamed view

Remove unnecessary var

Remove useless new line

Refactor updateEditorVisibility with better method and argument name

Add missing coma

Fix comment

Simplify editor focus handling

Apply suggestions from code review