Delete draft that cannot ever be sent because of corrupted attachments #2055
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LunarX
added
bug
Most of the sentry issues we receive regarding corrupted attachments come from drafts stored in DB that are retried everytime the worker is started. This bug was caused by the UploadStatus crash inside addDraftBreadcrumbs() for certain. I suspect that there might remain other reasons for the corrupted attachment bug because even with the UploadStatus' runCatching() I did reproduce the corrupted attachement bug once. Also the issue did exist before the addDraftBreadcrumbs() addition and hasn't yet been fixed. The plan of this commit is to remove the drafts that will never be processed so they stop spamming Sentry. Once this goes live we can see the errors where the attachement is corrupted for another reason than UploadStatus and fix this as well
LunarX
force-pushed
the
investigate-corrupted-attachment
branch
from
e7890f7 to
a1db10a
Compare
KevinBoulongne
requested changes
Sep 27, 2024
app/src/main/java/com/infomaniak/mail/workers/DraftsActionsWorker.kt
Outdated
Show resolved
Hide resolved
KevinBoulongne
approved these changes
Sep 27, 2024
|
tevincent
approved these changes
Sep 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Most of the sentry issues we receive regarding corrupted attachments come from drafts stored in DB that are retried everytime the worker is started. This bug was caused by the UploadStatus crash inside addDraftBreadcrumbs() for certain. I suspect that there might remain other reasons for the corrupted attachment bug because even with the UploadStatus' runCatching() I did reproduce the corrupted attachement bug once. Also the issue did exist before the addDraftBreadcrumbs() addition and hasn't yet been fixed.
The plan of this PR is to remove the drafts that will never be processed so they stop spamming Sentry. Once this goes live we can see the errors where the attachement is corrupted for another reason than UploadStatus and fix this as well