Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add missing parameters in Mailbox.initLocalValues() #2057

Merged
merged 1 commit into from
Sep 27, 2024
Merged

Add missing parameters in Mailbox.initLocalValues() #2057

merged 1 commit into from
Sep 27, 2024

Conversation

KevinBoulongne
Copy link
Contributor

No description provided.

tevincent
tevincent requested changes Sep 27, 2024
View reviewed changes
Copy link
Contributor

@tevincent tevincent left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Brain overloaded 🤯

Capture d’écran 2024-09-27 à 10 38 32

@tevincent tevincent added the rebase Add this label to rebase the PR label Sep 27, 2024
@github-actions github-actions bot removed the rebase Add this label to rebase the PR label Sep 27, 2024
@NicolasBourdin88 NicolasBourdin88 added the rebase Add this label to rebase the PR label Sep 27, 2024
@github-actions github-actions bot removed the rebase Add this label to rebase the PR label Sep 27, 2024
@tevincent
Copy link
Contributor

Stop spamming the rebase label @NicolasBourdin88

Capture d’écran 2024-09-27 à 10 42 03

@valentinperignon valentinperignon added the rebase Add this label to rebase the PR label Sep 27, 2024
@github-actions github-actions bot removed the rebase Add this label to rebase the PR label Sep 27, 2024
@KevinBoulongne KevinBoulongne added the rebase Add this label to rebase the PR label Sep 27, 2024
@github-actions github-actions bot removed the rebase Add this label to rebase the PR label Sep 27, 2024
tevincent
tevincent requested changes Sep 27, 2024
View reviewed changes
Copy link
Contributor

@tevincent tevincent left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we really want to accept that issue ? 😔

Capture d’écran 2024-09-27 à 11 15 19

@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
1 Accepted issue

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@KevinBoulongne KevinBoulongne merged commit 0662115 into master Sep 27, 2024
4 checks passed
@KevinBoulongne KevinBoulongne deleted the fix-BIMI-blink branch September 27, 2024 11:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@LunarX LunarX LunarX approved these changes

@tevincent tevincent tevincent approved these changes

Assignees

@KevinBoulongne KevinBoulongne

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@KevinBoulongne @tevincent @LunarX @valentinperignon @NicolasBourdin88