feat: Add missing schedule date format in ThreadListFragment #2164
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LunarX
force-pushed
the
fix-missing-schedule-date-format
branch
from
d5a0fe8 to
6527d12
Compare
TommyDL-Infomaniak
requested changes
Feb 17, 2025
app/src/main/java/com/infomaniak/mail/ui/main/folder/DateDisplay.kt
Outdated
Show resolved
Hide resolved
…cision namming The method does format future dates in a specific way so it can't be called "formatPastDate"
LunarX
force-pushed
the
fix-missing-schedule-date-format
branch
from
99141e0 to
7b30541
Compare
TommyDL-Infomaniak
approved these changes
Feb 17, 2025
tevincent
approved these changes
Feb 17, 2025
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The scheduled threads need to have a new relative formatting of the date which was missing in the original scheduled message feature. This PR adds the missing formatting and lays the groundwork for the snooze as well.
The existing default case logic for formatting dates has simply been moved to the new DateDisplay class without modifications. The name of the XML ImageView holding the "scheduled" icon has been renamed with a more neutral name to easily be reused for snooze