feat: Make Schedule choice bottom sheet generic to be shared with snooze #2194
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tevincent
approved these changes
Feb 21, 2025
LunarX
force-pushed
the
generic-date-bottom-sheet
branch
from
a0f7671 to
3780a50
Compare
tevincent
approved these changes
Feb 21, 2025
TommyDL-Infomaniak
requested changes
Feb 21, 2025
app/src/main/java/com/infomaniak/mail/ui/bottomSheetDialogs/SelectScheduleOptionBottomSheet.kt
Outdated
Show resolved
Hide resolved
Co-authored-by: Tommy Di Luna <[email protected]>
|
TommyDL-Infomaniak
approved these changes
Feb 21, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This bottom sheet will be reused for the snooze feature but with some slight differences. I abstracted the common logic in a single abstract class and left the specific logic in the schedule-specific bottom sheet implementation